You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/29 21:28:37 UTC

[GitHub] [iceberg] rdblue commented on pull request #5774: Clarify hash specification for date and boolean

rdblue commented on PR #5774:
URL: https://github.com/apache/iceberg/pull/5774#issuecomment-1262836879

   The intent here was to refer to the function defined for the `int` type. It looks like people are confusing these functions with hash specific methods in the hash implementation. I think it's fine to clarify, but this change makes the spec less specific because it removes the `long(value)` cast that is required for `int` and makes it implicit.
   
   Can we rephrase the change here so that it is simply clear that the hash for date depends on the hash for int?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org