You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/06 02:13:41 UTC
[GitHub] [arrow] marcprux opened a new pull request #9110: Better BigInt compatibility check
marcprux opened a new pull request #9110:
URL: https://github.com/apache/arrow/pull/9110
Check for whether `BigInt64ArrayAvailable` and `BigUint64ArrayAvailable` are available, rather than just `BigIntAvailable`. Recent versions of JavaScriptCore/WebKit in Safari support `BigInt` but do not support `BigInt64Array`, and so anything that relies on `BigInt64Array` will fail despite `BigIntAvailable` being `true`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #9110: ARROW-11706: [JS] Better BigInt compatibility check
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #9110:
URL: https://github.com/apache/arrow/pull/9110#issuecomment-827008711
@trxcllnt said that instead of this change, we should remove the JSON IPC classes from the npm packages and only have them in the integration tests. Can we close this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] marcprux commented on pull request #9110: Better BigInt compatibility check
Posted by GitBox <gi...@apache.org>.
marcprux commented on pull request #9110:
URL: https://github.com/apache/arrow/pull/9110#issuecomment-755037149
The manifestation of this issue can be seen when trying to run the following within Safari on a table that contains bigints:
```js
RecordBatchJSONWriter.writeAll(table).toString(true)
```
```error
message: "BigUint64Array is not available in this environment"
BigUint64ArrayUnavailableError
BigUint64ArrayUnavailable
bignumToString
bigNumsToStrings
generatorResume@[native code]
performIteration@[native code]
visitInt
visit
map@[native code]
recordBatchToJSON
close
finish
global code
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9110: ARROW-11706: [JS] Better BigInt compatibility check
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9110:
URL: https://github.com/apache/arrow/pull/9110#issuecomment-782550121
https://issues.apache.org/jira/browse/ARROW-11706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dianaclarke commented on pull request #9110: Better BigInt compatibility check
Posted by GitBox <gi...@apache.org>.
dianaclarke commented on pull request #9110:
URL: https://github.com/apache/arrow/pull/9110#issuecomment-782547787
Thanks for the pull request!
I've created a Jira ticket for you:
https://issues.apache.org/jira/browse/ARROW-11706
If you could update the PR subject to `ARROW-11706: [JS] Better BigInt compatibility check`, you might have better luck catching the eye of JS Arrow reviewers (which I am not).
Thanks again & stay safe!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] marcprux commented on pull request #9110: Better BigInt compatibility check
Posted by GitBox <gi...@apache.org>.
marcprux commented on pull request #9110:
URL: https://github.com/apache/arrow/pull/9110#issuecomment-755061487
See also: https://bugs.webkit.org/show_bug.cgi?id=190800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz closed pull request #9110: ARROW-11706: [JS] Better BigInt compatibility check
Posted by GitBox <gi...@apache.org>.
domoritz closed pull request #9110:
URL: https://github.com/apache/arrow/pull/9110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] trxcllnt commented on pull request #9110: ARROW-11706: [JS] Better BigInt compatibility check
Posted by GitBox <gi...@apache.org>.
trxcllnt commented on pull request #9110:
URL: https://github.com/apache/arrow/pull/9110#issuecomment-816272924
@kou Yeah, it looks good to me :+1:
@marcprux we _strongly_ recommend against using the JSON format outside the Arrow CI integration tests, and may remove the JSON IPC classes from the npm packages soon as part of slimming down the ArrowJS bundle sizes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9110: Better BigInt compatibility check
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9110:
URL: https://github.com/apache/arrow/pull/9110#issuecomment-755031124
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9110: ARROW-11706: [JS] Better BigInt compatibility check
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9110:
URL: https://github.com/apache/arrow/pull/9110#issuecomment-816253533
@trxcllnt Can we merge this?
@marcprux Could you tell us your JIRA account? I want to assign you to https://issues.apache.org/jira/browse/ARROW-11706 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org