You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tv42 (via GitHub)" <gi...@apache.org> on 2023/05/25 23:25:08 UTC

[GitHub] [arrow-datafusion] tv42 opened a new issue, #6450: Panics if racing against catalog/schema changes

tv42 opened a new issue, #6450:
URL: https://github.com/apache/arrow-datafusion/issues/6450

   ### Describe the bug
   
   InformationSchemaConfig assumes every schema in list returned from `schema_names` is still present when it gets to them, but if the schema can change e.g. due to concurrent action by a second user, this will panic:
   
   https://github.com/apache/arrow-datafusion/blob/444f0c42c4f37103c51eb8e0e92ad140727ca16f/datafusion/core/src/catalog/information_schema.rs#L79-L84
   
   My recommendation would be to either change the trait to add a method iterating (name, schema) tuples, or in this case just `if let Some(schema) = catalog.schema(&schema_name) { ...` would be enough.
   
   There's probably a similar race-induced panic on the other levels too, for catalog/schema/table.
   
   ### To Reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #6450: Panics if racing against catalog/schema changes

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #6450: Panics if racing against catalog/schema changes
URL: https://github.com/apache/arrow-datafusion/issues/6450


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #6450: Panics if racing against catalog/schema changes

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6450:
URL: https://github.com/apache/arrow-datafusion/issues/6450#issuecomment-1572576043

   I agree that ignoring the error (with a comment explaining why) is probably a reasonable workaround. I think this is a good first issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org