You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/22 05:49:58 UTC

[GitHub] feng-tao commented on a change in pull request #4560: [AIRFLOW-3733] Init variable i avoid raise NameError

feng-tao commented on a change in pull request #4560: [AIRFLOW-3733] Init variable i avoid raise NameError
URL: https://github.com/apache/airflow/pull/4560#discussion_r249647958
 
 

 ##########
 File path: airflow/hooks/hive_hooks.py
 ##########
 @@ -878,6 +878,7 @@ def to_csv(
         header = next(results_iter)
         message = None
 
+        i = 0
 
 Review comment:
   if log error, shouldn't we change L904 instead? If we set i = 0, then it will get shadowed in L892.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services