You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/10 16:14:45 UTC

[GitHub] [hbase] busbey commented on a change in pull request #1862: HBASE-24466 Release scripts in docker mode should be able to use a named volume for maven repo

busbey commented on a change in pull request #1862:
URL: https://github.com/apache/hbase/pull/1862#discussion_r438247409



##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -173,6 +176,12 @@ if [ -n "$JAVA" ]; then
   JAVA_VOL=(--volume "$JAVA:/opt/hbase-java")
 fi
 
+MAVEN_MOUNT=()
+if [ -n "${MAVEN_VOLUME}" ]; then
+  MAVEN_MOUNT=(--mount "type=volume,src=${MAVEN_VOLUME},dst=/home/hbase-rm/.m2-repository/")
+  echo "REPO=/home/hbase-rm/.m2-repository" >> "${ENVFILE}"

Review comment:
       it's in the container. since #1620 hasn't landed yet the container user is still hard-coded to `hbase-rm`. The goal is to be able to reuse the .m2 for third party dependencies across container invocations.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org