[GitHub] rabbah commented on a change in pull request #3615: Terminate route for invalid list skip values

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3615: Terminate route for invalid list skip values
URL: https://github.com/apache/incubator-openwhisk/pull/3615#discussion_r186581703
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/http/ErrorResponse.scala
 ##########
 @@ -151,9 +151,12 @@ object Messages {
   }
 
   def listLimitOutOfRange(collection: String, value: Int, max: Int) = {
-    s"The value $value is not in the range of 0 to $max for $collection."
+    s"The value '$value' is not in the range of 0 to $max for $collection."
   }
-  def listLimitIsNotAString = s"The API expects the 'limit' value to be an integer but the given value is not."
+  def listSkipOutOfRange(collection: String, value: Int) = {
+    s"The value '$value' is not a non-negative integer for $collection."
 
 Review comment:
   Avoid double negative - “must be greater than or equal to 0”?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services