[GitHub] [doris] morningman commented on a diff in pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog

[GitBox <gi...@apache.org>]

morningman commented on code in PR #15780:
URL: https://github.com/apache/doris/pull/15780#discussion_r1066727778


##########
fe/fe-core/src/main/java/org/apache/doris/external/jdbc/JdbcClient.java:
##########
@@ -486,6 +500,68 @@ public Type postgresqlTypeToDoris(JdbcFieldSchema fieldSchema) {
         }
     }
 
+    public Type clickhouseTypeToDoris(JdbcFieldSchema fieldSchema) {
+        String ckType = fieldSchema.getDataTypeName();
+        if (ckType.startsWith("LowCardinality")) {
+            ckType = ckType.substring(15, ckType.length() - 1);
+        }
+        if (ckType.startsWith("Nullable")) {
+            ckType = ckType.substring(9, ckType.length() - 1);
+        }
+        if (ckType.startsWith("Decimal")) {

Review Comment:
   Should be use `if else` for these conditions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org