You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by dm...@apache.org on 2020/05/15 13:49:44 UTC
[hive] branch master updated: HIVE-18882: Minor Logging Improvements in Hive Metastore Client Connection (David Mollitor, reviewed by László Bodor)
This is an automated email from the ASF dual-hosted git repository.
dmollitor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push:
new 47d2fe1 HIVE-18882: Minor Logging Improvements in Hive Metastore Client Connection (David Mollitor, reviewed by László Bodor)
47d2fe1 is described below
commit 47d2fe19052ebc9192a05d6777cffa11aa79b82a
Author: David Mollitor <da...@cloudera.com>
AuthorDate: Fri May 15 09:48:06 2020 -0400
HIVE-18882: Minor Logging Improvements in Hive Metastore Client Connection (David Mollitor, reviewed by László Bodor)
---
.../apache/hadoop/hive/metastore/HiveMetaStoreClient.java | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java b/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
index 64d3833..65df9c2 100644
--- a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
+++ b/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
@@ -393,7 +393,7 @@ public class HiveMetaStoreClient implements IMetaStoreClient, AutoCloseable {
JavaUtils.getClassLoader());
return (URIResolverHook) ReflectionUtils.newInstance(uriResolverClass, null);
} catch (Exception e) {
- LOG.error("Exception loading uri resolver hook" + e);
+ LOG.error("Exception loading uri resolver hook", e);
return null;
}
}
@@ -576,14 +576,14 @@ public class HiveMetaStoreClient implements IMetaStoreClient, AutoCloseable {
for (int attempt = 0; !isConnected && attempt < retries; ++attempt) {
for (URI store : metastoreUris) {
- LOG.info("Trying to connect to metastore with URI (" + store + ")");
+ LOG.info("Trying to connect to metastore with URI ({})", store);
try {
if (useSSL) {
try {
String trustStorePath = MetastoreConf.getVar(conf, ConfVars.SSL_TRUSTSTORE_PATH).trim();
if (trustStorePath.isEmpty()) {
- throw new IllegalArgumentException(ConfVars.SSL_TRUSTSTORE_PATH.toString()
+ throw new IllegalArgumentException(ConfVars.SSL_TRUSTSTORE_PATH
+ " Not configured for SSL connection");
}
String trustStorePassword =
@@ -699,8 +699,6 @@ public class HiveMetaStoreClient implements IMetaStoreClient, AutoCloseable {
tte = e;
LOG.warn("Failed to connect to the MetaStore Server URI ({})",
store);
-
- // Include stack trace in DEBUG logging
LOG.debug("Failed to connect to the MetaStore Server URI ({})",
store, e);
}
@@ -3437,13 +3435,13 @@ public class HiveMetaStoreClient implements IMetaStoreClient, AutoCloseable {
NotificationEventRequest rqst = new NotificationEventRequest(lastEventId);
rqst.setMaxEvents(maxEvents);
NotificationEventResponse rsp = client.get_next_notification(rqst);
- LOG.debug("Got back " + rsp.getEventsSize() + " events");
+ LOG.debug("Got back {} events", rsp.getEventsSize());
NotificationEventResponse filtered = new NotificationEventResponse();
if (rsp != null && rsp.getEvents() != null) {
long nextEventId = lastEventId + 1;
long prevEventId = lastEventId;
for (NotificationEvent e : rsp.getEvents()) {
- LOG.debug("Got event with id : " + e.getEventId());
+ LOG.debug("Got event with id : {}", e.getEventId());
if (e.getEventId() != nextEventId) {
if (e.getEventId() == prevEventId) {
LOG.error("NOTIFICATION_LOG table has multiple events with the same event Id {}. " +