You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Yifei Wu (JIRA)" <ji...@apache.org> on 2018/05/25 03:09:00 UTC
[jira] [Commented] (KYLIN-3386) the TopN measure validate code
refactor to make it more clear
[ https://issues.apache.org/jira/browse/KYLIN-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490160#comment-16490160 ]
Yifei Wu commented on KYLIN-3386:
---------------------------------
here is the patch [^0001-KYLIN-3386-adjust-TopN-measure-validation-code.patch]
> the TopN measure validate code refactor to make it more clear
> -------------------------------------------------------------
>
> Key: KYLIN-3386
> URL: https://issues.apache.org/jira/browse/KYLIN-3386
> Project: Kylin
> Issue Type: Improvement
> Reporter: Yifei Wu
> Assignee: Yifei Wu
> Priority: Minor
> Attachments: 0001-KYLIN-3386-adjust-TopN-measure-validation-code.patch
>
>
> _Nowadays, the FunctionRule used for validating measure info, and it should call measureType.validate() code rather than add the logical in this 2 places_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)