You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/03 08:35:17 UTC
[GitHub] [pulsar] freeznet opened a new pull request #9445: enhance kubernetes manifest customizer with default options
freeznet opened a new pull request #9445:
URL: https://github.com/apache/pulsar/pull/9445
### Motivation
The KubernetesManifestCustomizer was introduced by customizing the stateful set of running Pulsar Functions. but no default value was loaded from `functions_worker.yaml`.
### Modifications
Add load default runtime options in `BasicKubernetesManifestCustomizer`
Add unit tests
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9445: [pulsar-functions] enhance kubernetes manifest customizer with default options
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9445:
URL: https://github.com/apache/pulsar/pull/9445#issuecomment-773860226
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9445: [pulsar-functions] enhance kubernetes manifest customizer with default options
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9445:
URL: https://github.com/apache/pulsar/pull/9445#issuecomment-773766222
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nlu90 commented on pull request #9445: [pulsar-functions] enhance kubernetes manifest customizer with default options
Posted by GitBox <gi...@apache.org>.
nlu90 commented on pull request #9445:
URL: https://github.com/apache/pulsar/pull/9445#issuecomment-772940743
LGTM except the above comment for importing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #9445: [pulsar-functions] enhance kubernetes manifest customizer with default options
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9445:
URL: https://github.com/apache/pulsar/pull/9445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9445: [pulsar-functions] enhance kubernetes manifest customizer with default options
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9445:
URL: https://github.com/apache/pulsar/pull/9445#issuecomment-773766222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nlu90 commented on a change in pull request #9445: [pulsar-functions] enhance kubernetes manifest customizer with default options
Posted by GitBox <gi...@apache.org>.
nlu90 commented on a change in pull request #9445:
URL: https://github.com/apache/pulsar/pull/9445#discussion_r569863044
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
##########
@@ -46,10 +46,7 @@
import org.apache.pulsar.functions.worker.WorkerConfig;
import java.lang.reflect.Field;
-import java.util.Map;
-import java.util.Optional;
-import java.util.Timer;
-import java.util.TimerTask;
+import java.util.*;
Review comment:
please avoid import "*"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9445: [pulsar-functions] enhance kubernetes manifest customizer with default options
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9445:
URL: https://github.com/apache/pulsar/pull/9445#issuecomment-772355847
@nlu90 Can you take a look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie edited a comment on pull request #9445: [pulsar-functions] enhance kubernetes manifest customizer with default options
Posted by GitBox <gi...@apache.org>.
sijie edited a comment on pull request #9445:
URL: https://github.com/apache/pulsar/pull/9445#issuecomment-772355847
@nlu90 @addisonj Can you take a look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org