You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by elilevine <gi...@git.apache.org> on 2015/07/09 03:47:58 UTC
[GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...
GitHub user elilevine opened a pull request:
https://github.com/apache/phoenix/pull/97
PHOENIX-978: Allow views to extend parent's PK only if parent's last …
…PK column is fixed length
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elilevine/apache-phoenix PHOENIX-978
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/97.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #97
----
commit 70a1828acd951fc67aed7b66f30270237c615929
Author: Eli Levine <el...@apache.org>
Date: 2015-07-09T01:46:43Z
PHOENIX-978: Allow views to extend parent's PK only if parent's last PK column is fixed length
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...
Posted by elilevine <gi...@git.apache.org>.
Github user elilevine commented on the pull request:
https://github.com/apache/phoenix/pull/97#issuecomment-129690323
Closing this PR. This has been checked in by @twdsilva.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...
Posted by elilevine <gi...@git.apache.org>.
Github user elilevine closed the pull request at:
https://github.com/apache/phoenix/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...
Posted by elilevine <gi...@git.apache.org>.
Github user elilevine commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/97#discussion_r34219051
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java ---
@@ -2132,15 +2131,13 @@ public void testAddExistingViewColumnToBaseTableWithViews() throws Exception {
}
@Test
- @Ignore
- // enable this test after https://issues.apache.org/jira/browse/PHOENIX-978 is fixed
public void testAddExistingViewPkColumnToBaseTableWithViews() throws Exception {
Connection conn = DriverManager.getConnection(getUrl());
try {
conn.createStatement().execute("CREATE TABLE IF NOT EXISTS TABLEWITHVIEW ("
+ " ID char(10) NOT NULL,"
+ " COL1 integer NOT NULL,"
- + " COL2 bigint NOT NULL,"
+ + " COL2 integer NOT NULL,"
--- End diff --
Parent's last PK column must be fixed-length now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...
Posted by elilevine <gi...@git.apache.org>.
Github user elilevine commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/97#discussion_r34219079
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java ---
@@ -2179,7 +2176,7 @@ public void testAddExistingViewPkColumnToBaseTableWithViews() throws Exception {
assertEquals(rs.getString(1), "view1");
assertEquals(rs.getInt(2), 12);
assertEquals(rs.getInt(3), 13);
- assertEquals(rs.getInt(4), 14);
+ assertEquals(rs.getBigDecimal(4).intValue(), 14);
--- End diff --
Had to make this change, otherwise was getting BigDecimal rounding errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---