[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11668: [Bug-11650][worker] #11650 fix SQL type task, stop task does not take effect

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #11668:
URL: https://github.com/apache/dolphinscheduler/pull/11668#discussion_r956726286


##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskKillProcessor.java:
##########
@@ -94,8 +94,14 @@ public void process(Channel channel, Command command) {
         }
 
         int processId = taskExecutionContext.getProcessId();
-        if (processId == 0) {
-            this.cancelApplication(taskInstanceId);
+
+        this.cancelApplication(taskInstanceId);
+
+        Pair<Boolean, List<String>> result = doKill(taskExecutionContext);

Review Comment:
   I don't think we need to do this change, if the task is execute in worker's thread, the processId is 0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org