You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/16 18:37:53 UTC

[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #75: [FLINK-26640] Make FlinkVersion enum and required

gyfora commented on a change in pull request #75:
URL: https://github.com/apache/flink-kubernetes-operator/pull/75#discussion_r828302232



##########
File path: helm/flink-operator/crds/flinkdeployments.flink.apache.org-v1.yml
##########
@@ -26,6 +26,22 @@ spec:
               serviceAccount:
                 type: string
               flinkVersion:
+                enum:
+                - v1_3

Review comment:
       I don't have a problem with having our own enum either (that way we would have immediate validation for the accepted versions). @wangyang0918 , @morhidi what do you think? 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org