You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Cornwall (JIRA)" <ji...@apache.org> on 2008/03/14 17:48:24 UTC
[jira] Created: (HARMONY-5607) [classlib][pack200] Inner class
handling is wrong
[classlib][pack200] Inner class handling is wrong
-------------------------------------------------
Key: HARMONY-5607
URL: https://issues.apache.org/jira/browse/HARMONY-5607
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: All pack200
Reporter: Andrew Cornwall
The way that inner classes are handled is incorrect. Right now, many classes which should not be added to a class are being added. (For instance, an inner class of Foo$2 will incorrectly have Foo$1 added to its classpool as well.) This patch corrects the defect.
In addition, this patch fixes a defect in handling the SourceFileAttribute. It was being ignored if it was specified - which is bad news if IMyInterface came from MyClass.java instead of IMyInterface.java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5607) [classlib][pack200] Inner class
handling is wrong
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5607:
-------------------------------------
Attachment: main.patch
main.patch contains code to implement these changes
> [classlib][pack200] Inner class handling is wrong
> -------------------------------------------------
>
> Key: HARMONY-5607
> URL: https://issues.apache.org/jira/browse/HARMONY-5607
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Attachments: main.patch
>
>
> The way that inner classes are handled is incorrect. Right now, many classes which should not be added to a class are being added. (For instance, an inner class of Foo$2 will incorrectly have Foo$1 added to its classpool as well.) This patch corrects the defect.
> In addition, this patch fixes a defect in handling the SourceFileAttribute. It was being ignored if it was specified - which is bad news if IMyInterface came from MyClass.java instead of IMyInterface.java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5607) [classlib][pack200] Inner class
handling is wrong
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January reassigned HARMONY-5607:
-------------------------------------
Assignee: Sian January
> [classlib][pack200] Inner class handling is wrong
> -------------------------------------------------
>
> Key: HARMONY-5607
> URL: https://issues.apache.org/jira/browse/HARMONY-5607
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Attachments: main.patch
>
>
> The way that inner classes are handled is incorrect. Right now, many classes which should not be added to a class are being added. (For instance, an inner class of Foo$2 will incorrectly have Foo$1 added to its classpool as well.) This patch corrects the defect.
> In addition, this patch fixes a defect in handling the SourceFileAttribute. It was being ignored if it was specified - which is bad news if IMyInterface came from MyClass.java instead of IMyInterface.java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5607) [classlib][pack200] Inner class
handling is wrong
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January resolved HARMONY-5607.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M6
Patch applied in r638423. Please check that it was applied as you expected.
> [classlib][pack200] Inner class handling is wrong
> -------------------------------------------------
>
> Key: HARMONY-5607
> URL: https://issues.apache.org/jira/browse/HARMONY-5607
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M6
>
> Attachments: main.patch
>
>
> The way that inner classes are handled is incorrect. Right now, many classes which should not be added to a class are being added. (For instance, an inner class of Foo$2 will incorrectly have Foo$1 added to its classpool as well.) This patch corrects the defect.
> In addition, this patch fixes a defect in handling the SourceFileAttribute. It was being ignored if it was specified - which is bad news if IMyInterface came from MyClass.java instead of IMyInterface.java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5607) [classlib][pack200] Inner class
handling is wrong
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall closed HARMONY-5607.
------------------------------------
Patch applied as expected. Thanks!
> [classlib][pack200] Inner class handling is wrong
> -------------------------------------------------
>
> Key: HARMONY-5607
> URL: https://issues.apache.org/jira/browse/HARMONY-5607
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M6
>
> Attachments: main.patch
>
>
> The way that inner classes are handled is incorrect. Right now, many classes which should not be added to a class are being added. (For instance, an inner class of Foo$2 will incorrectly have Foo$1 added to its classpool as well.) This patch corrects the defect.
> In addition, this patch fixes a defect in handling the SourceFileAttribute. It was being ignored if it was specified - which is bad news if IMyInterface came from MyClass.java instead of IMyInterface.java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.