You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/01/12 09:35:01 UTC
Review Request 65120: [ATLAS-2357]: Fix IT failures in hive-bridge
module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65120/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-2357
https://issues.apache.org/jira/browse/ATLAS-2357
Repository: atlas
Description
-------
Fix IT failures in hive-bridge module
Diffs (updated)
-----
addons/hive-bridge/pom.xml 9421e326
addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java b4ea3f9b
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 262f7dc5
addons/hive-bridge/src/test/resources/atlas-application.properties PRE-CREATION
addons/hive-bridge/src/test/resources/atlas-log4j.xml PRE-CREATION
addons/hive-bridge/src/test/resources/hive-site.xml 876f41de
addons/hive-bridge/src/test/resources/policy-store.txt PRE-CREATION
addons/hive-bridge/src/test/resources/users-credentials.properties PRE-CREATION
pom.xml c64b26e5
test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java cdcac647
webapp/pom.xml 2cf6e103
webapp/src/test/resources/atlas-application.properties PRE-CREATION
webapp/src/test/resources/policy-store.txt PRE-CREATION
webapp/src/test/resources/users-credentials.properties PRE-CREATION
Diff: https://reviews.apache.org/r/65120/diff/1/
Testing (updated)
-------
43/45 ITs succeeds in hive-bridge module.
Failed tests:
HiveHookIT.testDropDatabaseWithCascade:1460->assertDBIsNotRegistered:1800->assertEntityIsNotRegistered:1808->HiveITBase.waitFor:209 Assertions failed. Failing after waiting for timeout 5000 msecs
HiveHookIT.testDropDatabaseWithoutCascade:1493 Entity was not supposed to exist for typeName = hive_db, attributeName = qualifiedName, attributeValue = dbnri3pj9l4u@primary
Tests run: 45, Failures: 2, Errors: 0, Skipped: 0
Thanks,
Sarath Subramanian
Re: Review Request 65120: [ATLAS-2357]: Fix IT failures in
hive-bridge module
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65120/#review195332
-----------------------------------------------------------
Fix it, then Ship it!
addons/hive-bridge/src/test/resources/atlas-application.properties
Lines 33 (patched)
<https://reviews.apache.org/r/65120/#comment274505>
This file includes few properties that are not used anymore, like:
atlas.TypeSystem.impl
atlas.db
atlas.search.gremlin.enable
This file and other such properties files should be reviewed and updated to purge unused entries. We can track this in a separate commit.
- Madhan Neethiraj
On Jan. 12, 2018, 6:35 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65120/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2018, 6:35 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2357
> https://issues.apache.org/jira/browse/ATLAS-2357
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix IT failures in hive-bridge module
>
>
> Diffs
> -----
>
> addons/hive-bridge/pom.xml 9421e326
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 2d2a9bf3
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java b4ea3f9b
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 262f7dc5
> addons/hive-bridge/src/test/resources/atlas-application.properties PRE-CREATION
> addons/hive-bridge/src/test/resources/atlas-log4j.xml PRE-CREATION
> addons/hive-bridge/src/test/resources/hive-site.xml 876f41de
> addons/hive-bridge/src/test/resources/policy-store.txt PRE-CREATION
> addons/hive-bridge/src/test/resources/users-credentials.properties PRE-CREATION
> pom.xml c64b26e5
> test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java cdcac647
> webapp/pom.xml 2cf6e103
> webapp/src/test/resources/atlas-application.properties PRE-CREATION
> webapp/src/test/resources/policy-store.txt PRE-CREATION
> webapp/src/test/resources/users-credentials.properties PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65120/diff/3/
>
>
> Testing
> -------
>
> 44/45 ITs succeeds in hive-bridge module.
>
> Failed tests:
> HiveHookIT.testDropDatabaseWithoutCascade:1493 Entity was not supposed to exist for typeName = hive_db, attributeName = qualifiedName, attributeValue = db0m1a9umv4s@primary
>
> Tests run: 45, Failures: 1, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 65120: [ATLAS-2357]: Fix IT failures in
hive-bridge module
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65120/
-----------------------------------------------------------
(Updated Jan. 12, 2018, 10:35 a.m.)
Review request for atlas.
Changes
-------
Fixed UT failures
Bugs: ATLAS-2357
https://issues.apache.org/jira/browse/ATLAS-2357
Repository: atlas
Description
-------
Fix IT failures in hive-bridge module
Diffs (updated)
-----
addons/hive-bridge/pom.xml 9421e326
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 2d2a9bf3
addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java b4ea3f9b
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 262f7dc5
addons/hive-bridge/src/test/resources/atlas-application.properties PRE-CREATION
addons/hive-bridge/src/test/resources/atlas-log4j.xml PRE-CREATION
addons/hive-bridge/src/test/resources/hive-site.xml 876f41de
addons/hive-bridge/src/test/resources/policy-store.txt PRE-CREATION
addons/hive-bridge/src/test/resources/users-credentials.properties PRE-CREATION
pom.xml c64b26e5
test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java cdcac647
webapp/pom.xml 2cf6e103
webapp/src/test/resources/atlas-application.properties PRE-CREATION
webapp/src/test/resources/policy-store.txt PRE-CREATION
webapp/src/test/resources/users-credentials.properties PRE-CREATION
Diff: https://reviews.apache.org/r/65120/diff/3/
Changes: https://reviews.apache.org/r/65120/diff/2-3/
Testing
-------
44/45 ITs succeeds in hive-bridge module.
Failed tests:
HiveHookIT.testDropDatabaseWithoutCascade:1493 Entity was not supposed to exist for typeName = hive_db, attributeName = qualifiedName, attributeValue = db0m1a9umv4s@primary
Tests run: 45, Failures: 1, Errors: 0, Skipped: 0
Thanks,
Sarath Subramanian