You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/18 23:16:25 UTC
[GitHub] [commons-beanutils] SethFalco opened a new pull request #91: chore: remove redundant whitespace
SethFalco opened a new pull request #91:
URL: https://github.com/apache/commons-beanutils/pull/91
Would it be fine to refactor or reformat parts of the repository?
I'd like to contribute more, but I thought it could be nice to clean things up a bit, especially the unit tests.
This PR removes 3,000+ redundant lines, as they were a bit annoying while browsing the repo. ^-^'
* Removes trailing white space characters.
* Removes redundant line breaks.
* Fixes indentation of certain functions that used 2 spaces instead of 4.
### Examples
#### Multiple Line Breaks
```java
public void functionA() {
}
public void functionB() {
}
```
#### Line Break At Start and End of Method
```java
public void myFunction() {
doA();
doB();
}
```
#### Trailing Blank Lines in Docs
```java
/**
* Documentation for the class.
*
*/
public class MyClass {
}
```
#### Next Line Curly Instead of Inline
```java
try {
}
catch (Exception ex) {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory commented on pull request #91: chore: remove redundant whitespace
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #91:
URL: https://github.com/apache/commons-beanutils/pull/91#issuecomment-885261148
@SethFalco
Sorry, I'm not going to review 253 files :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] SethFalco commented on pull request #91: chore: remove redundant whitespace
Posted by GitBox <gi...@apache.org>.
SethFalco commented on pull request #91:
URL: https://github.com/apache/commons-beanutils/pull/91#issuecomment-885262118
No worries, I'll close this then.
I'll just clean up the relevant files when doing other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] SethFalco closed pull request #91: chore: remove redundant whitespace
Posted by GitBox <gi...@apache.org>.
SethFalco closed pull request #91:
URL: https://github.com/apache/commons-beanutils/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org