DO NOT REPLY [Bug 32341] - [Shale] org.apache.shale.Constants breaks OOP

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=32341>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32341





------- Additional Comments From sean.schofield@gmail.com  2005-01-18 04:55 -------
+1 for this change.  

Its not considered good practice to have constants declared as an iterface.  
The primary purpose to do this is so people can be lazy and have their classes 
implement the interfaces so they can refer to the constants without saying 
ShaleConstants.FOO, etc.  I realize this isn't being done right now in shale 
but its possible as an interface.

Joshua Bloch has a good write up on this in Effective Java.  He lists a lot of 
reasons why this isn't a good idea.  I won't go into it, however, because 
Craig seems to agree with this point.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org