You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/12 08:52:00 UTC

[jira] [Commented] (PARQUET-1719) Make ParquetReader(List, ParquetReadOptions, ReadSupport) constructor public

    [ https://issues.apache.org/jira/browse/PARQUET-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994400#comment-16994400 ] 

ASF GitHub Bot commented on PARQUET-1719:
-----------------------------------------

dssysolyatin commented on pull request #707: [PARQUET-1719] Make ParquetReader(List<InputFile>, ParquetReadOptions, ReadSupport<T>) constructor public
URL: https://github.com/apache/parquet-mr/pull/707
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [PARQUET-1719](https://issues.apache.org/jira/browse/PARQUET-1719) issues "PARQUET-1719: Make ParquetReader(List<InputFile>, ParquetReadOptions, ReadSupport<T>) constructor public"
   
   ### Tests
   
   - [ ] My PR does not need testing for this extremely good reason: No new functions were added
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make ParquetReader(List<InputFile>, ParquetReadOptions, ReadSupport<T>) constructor public
> ------------------------------------------------------------------------------------------
>
>                 Key: PARQUET-1719
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1719
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-mr
>            Reporter: Dmitry Sysolyatin
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>
> My application uses s3 storage to store parquet files. The problem is that there is not ability to get rid from `new Configuration(true);` which load configuration from files: 
> `core-default.xml` and `core-site.xml` every time when ParquetReader instance is created.
> I suggest just make ParquetReader(List<InputFile>, ParquetReadOptions, ReadSupport<T>) constructor public then there will be ability to do custom builder.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)