You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 05:01:23 UTC

[GitHub] [airflow] dstandish opened a new pull request #12936: shorten name of hook re imports of provide_session and create_session

dstandish opened a new pull request #12936:
URL: https://github.com/apache/airflow/pull/12936


   I noticed that the hook name was very long.  107 characters actually.  
   
   ```To avoid import cycles make sure provide_session and create_session are imported from airflow.utils.session```
   
   If your terminal is only 100 chars, then this makes it very ugly and hard to read.
   
   Here I make the name shorter and to the point, and move the comments on motivatio -- previously part of hook name -- to the description.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dstandish commented on pull request #12936: shorten pre-commit hook name re imports of provide_session etc

Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #12936:
URL: https://github.com/apache/airflow/pull/12936#issuecomment-741551112


   i thought you would like this one ;) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #12936: shorten pre-commit hook name re imports of provide_session etc

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12936:
URL: https://github.com/apache/airflow/pull/12936#issuecomment-741568330


   It's ok :). Those descriptions are rarely read but useful when things fail :).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dstandish commented on pull request #12936: shorten pre-commit hook name re imports of provide_session etc

Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #12936:
URL: https://github.com/apache/airflow/pull/12936#issuecomment-741554074


   In hindsight i see there is somewhat of a "Make sure" convention for these type of checks... if you want i can add that to start @potiuk .... would still be reasonable length....   otherwise i leave it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #12936: shorten pre-commit hook name re imports of provide_session etc

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12936:
URL: https://github.com/apache/airflow/pull/12936


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #12936: shorten pre-commit hook name re imports of provide_session etc

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12936:
URL: https://github.com/apache/airflow/pull/12936#issuecomment-741536673


   nice :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org