[jira] [Resolved] (OAK-5164) ChangeSet's maxPathDepth must be taken into account by ChangeSetFilterImpl

["Stefan Egli (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Egli resolved OAK-5164.
------------------------------
    Resolution: Fixed

implemented a fail-stop: when maxPathDepth is 'hit', the ChangeSetFilterImpl in {{excludes()}} stops further processing and return false (ie _includes_): http://svn.apache.org/viewvc?rev=1771733&view=rev

> ChangeSet's maxPathDepth must be taken into account by ChangeSetFilterImpl
> --------------------------------------------------------------------------
>
>                 Key: OAK-5164
>                 URL: https://issues.apache.org/jira/browse/OAK-5164
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.5.14
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>            Priority: Critical
>             Fix For: 1.5.15
>
>
> The ChangeSet stops collecting paths that are deeper than {{maxPathDepth}}. This is to avoid collecting too much detail (and overflow the ChangeSet) given normally filters' includePaths are only a few levels deep.
> This information is currently however not yet used by the ChangeSetFilterImpl. This is wrong and must be fixed. At the moment it's not a realistic problem though as the {{maxPathDepth}} is 9 and typically filters have include paths of perhaps 2-4. But with ChangeSet merging (OAK-5126) that figure of 9 might come down, so accounting for {{maxPathDepth}} in the filter must be done at some point.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)