You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "featuriz (via GitHub)" <gi...@apache.org> on 2023/01/31 16:32:27 UTC
[GitHub] [netbeans] featuriz opened a new pull request, #5397: chang to .yaml as per official YAML
featuriz opened a new pull request, #5397:
URL: https://github.com/apache/netbeans/pull/5397
As per YAML documentation file extension is .yaml not .yml 'The official recommended filename extension for YAML files has been .yaml since 2006'
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] featuriz commented on pull request #5397: chang to .yaml as per official YAML
Posted by "featuriz (via GitHub)" <gi...@apache.org>.
featuriz commented on PR #5397:
URL: https://github.com/apache/netbeans/pull/5397#issuecomment-1410700893
Update as per YAML documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5397: chang to .yaml as per official YAML
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5397:
URL: https://github.com/apache/netbeans/pull/5397#issuecomment-1410781828
Needs to be updated with the additional change from #5397 and should also document how the change was checked.
While doing the update please also check that the author information is complete. You can check it by running `git log -n 1` from the branch that holds the corresponding change. In this case the author email ends with `users.noreply.github.com`, which is obviously not correct.
Please also check the correct spelling of the commit message. I suggest:
> Change extension of YAML template file to .yaml as per official YAML specification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5397: chang to .yaml as per official YAML
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5397:
URL: https://github.com/apache/netbeans/pull/5397#issuecomment-1416220890
@featuriz not sure what is your problem. I reviewed your code and it needs to be fixed (as pointed out in the first sentence). Then I checked the author information. It is required to be correct and it was not. When both of these were done I _also_ mentioned, that you should update the commit message. I even suggested a replacement.
If you feel offended by that sorry, but it was not meant so.
You are welcome to reopen this PR with the required changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] featuriz commented on pull request #5397: chang to .yaml as per official YAML
Posted by "featuriz (via GitHub)" <gi...@apache.org>.
featuriz commented on PR #5397:
URL: https://github.com/apache/netbeans/pull/5397#issuecomment-1415025570
> Needs to be updated with the additional change from #5397 and should also document how the change was checked.
>
> While doing the update please also check that the author information is complete. You can check it by running `git log -n 1` from the branch that holds the corresponding change. In this case the author email ends with `users.noreply.github.com`, which is obviously not correct.
>
> Please also check the correct spelling of the commit message. I suggest:
>
> > Change extension of YAML template file to .yaml as per official YAML specification
@matthiasblaesing I point out there is a problem. You are finding spelling mistake in my wording. Good work in finding spelling mistake.
RIP Netbeans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed pull request #5397: chang to .yaml as per official YAML
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing closed pull request #5397: chang to .yaml as per official YAML
URL: https://github.com/apache/netbeans/pull/5397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists