[GitHub] madlib pull request #343: Linear Regression: Support for JSON and special ch...

[orhankislal <gi...@git.apache.org>]

Github user orhankislal commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/343#discussion_r245023325
  
    --- Diff: src/ports/postgres/modules/regress/linear.py_in ---
    @@ -185,10 +221,12 @@ def _validate_args(schema_madlib, source_table, out_table, dependent_varname,
         if grouping_cols is not None:
             _assert(grouping_cols != '',
                     "Linregr error: Invalid grouping columns name!")
    +        # grouping columns can be a valid expression as well, for eg.
    +        # a json expression (data->>'id'), so commenting this part.
             grouping_list = _string_to_array_with_quotes(grouping_cols)
    -        _assert(columns_exist_in_table(
    -            source_table, grouping_list, schema_madlib),
    -            "Linregr error: Grouping column does not exist!")
    +        #_assert(columns_exist_in_table(
    --- End diff --
    
    We should clean up these comments before the merge.


---