You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/01/18 12:00:50 UTC
Review Request 55673: Add UI UT for alerts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55673/
-----------------------------------------------------------
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-19611
https://issues.apache.org/jira/browse/AMBARI-19611
Repository: ambari
Description
-------
Add UI UT for alerts
Diffs
-----
ambari-web/app/assets/test/tests.js e42c811
ambari-web/app/controllers/main/alerts/definition_details_controller.js ea9b5b7
ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js a501a34
ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js 8501678
ambari-web/app/mappers/alert_definitions_mapper.js cd4e738
ambari-web/app/models/alerts/alert_config.js 1af02fc
ambari-web/app/models/alerts/alert_group.js 4f40ccf
ambari-web/app/models/alerts/alert_notification.js e503c6b
ambari-web/test/controllers/main/alerts/manage_alert_groups_controller_test.js 45c2a4c
ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js d63dcb8
ambari-web/test/models/alerts/alert_config_test.js 74a91f4
ambari-web/test/models/alerts/alert_group_test.js 036a32d
ambari-web/test/models/alerts/alert_notification_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/55673/diff/
Testing
-------
20454 tests complete (32 seconds)
153 tests pending
Thanks,
Oleg Nechiporenko
Re: Review Request 55673: Add UI UT for alerts
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55673/#review162074
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On Jan. 18, 2017, noon, Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55673/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, noon)
>
>
> Review request for Ambari and Andrii Tkach.
>
>
> Bugs: AMBARI-19611
> https://issues.apache.org/jira/browse/AMBARI-19611
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add UI UT for alerts
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js e42c811
> ambari-web/app/controllers/main/alerts/definition_details_controller.js ea9b5b7
> ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js a501a34
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js 8501678
> ambari-web/app/mappers/alert_definitions_mapper.js cd4e738
> ambari-web/app/models/alerts/alert_config.js 1af02fc
> ambari-web/app/models/alerts/alert_group.js 4f40ccf
> ambari-web/app/models/alerts/alert_notification.js e503c6b
> ambari-web/test/controllers/main/alerts/manage_alert_groups_controller_test.js 45c2a4c
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js d63dcb8
> ambari-web/test/models/alerts/alert_config_test.js 74a91f4
> ambari-web/test/models/alerts/alert_group_test.js 036a32d
> ambari-web/test/models/alerts/alert_notification_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55673/diff/
>
>
> Testing
> -------
>
> 20454 tests complete (32 seconds)
> 153 tests pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>