You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gabor Kaszab (Code Review)" <ge...@cloudera.org> on 2019/06/04 13:30:32 UTC
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13508
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
IMPALA-8612: Fix sporadic NPE when dropping an authorized table
In the analyze() function of DropTableOrViewStmt it's possible that
serverName_ is not set when analyzer.getTable() throws. As a result
when the Catalog executes the drop table DDL it runs into a failing
Precondition check and throws a NPE when updating user privileges.
Note, to run into the NPE it's required to have authorization enabled.
Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
---
M fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/13508/1
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
IMPALA-8612: Fix sporadic NPE when dropping an authorized table
In the analyze() function of DropTableOrViewStmt it's possible that
serverName_ is not set when analyzer.getTable() throws. As a result
when the Catalog executes the drop table DDL it runs into a failing
Precondition check and throws a NullPointerException when updating
user privileges. Note, to run into the NPE it's required to have
authorization enabled.
Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Reviewed-on: http://gerrit.cloudera.org:8080/13508
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 7
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3767/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 14:47:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3769/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 5
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 17:19:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@40
PS3, Line 40: Expr
Shouldn't this be DropTableOrViewStmt?
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@131
PS3, Line 131: "Ignoring TableLoadingException for " + dbName_ + "." + tableName_
nit: it's usually preferable to use the SLF4J log format, e.g. LOG.info("Ignoring TableLoadingException for {}.{}", dbName_, getTbl());
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@134
PS3, Line 134: tableName_
tableName_.toString() may print "db.tbl": https://github.com/apache/impala/blob/572c1278566ca329f3e47e5c2d7e13dd0c7967f7/fe/src/main/java/org/apache/impala/analysis/TableName.java#L85-L92, should we use getTbl() instead similar to L115 and L120?
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 17:24:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 6
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 16:43:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3751/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 13:57:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 5
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 16:40:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:
http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@124
PS1, Line 124: analyzer.addAccessEvent(new TAccessEvent(
> Should we log the exception?
We should have an E2E test here by having a table that is dropped externally.
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:30:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13508/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13508/1//COMMIT_MSG@7
PS1, Line 7: NPE
nit: might worth spell it out at least once.
http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:
http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@124
PS1, Line 124: analyzer.addAccessEvent(new TAccessEvent(
Should we log the exception?
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 13:56:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13508
to look at the new patch set (#5).
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
IMPALA-8612: Fix sporadic NPE when dropping an authorized table
In the analyze() function of DropTableOrViewStmt it's possible that
serverName_ is not set when analyzer.getTable() throws. As a result
when the Catalog executes the drop table DDL it runs into a failing
Precondition check and throws a NullPointerException when updating
user privileges. Note, to run into the NPE it's required to have
authorization enabled.
Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
---
M fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/13508/5
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 5
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4565/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 6
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 16:43:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13508/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13508/1//COMMIT_MSG@7
PS1, Line 7: NPE
> nit: might worth spell it out at least once.
Done
http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:
http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@124
PS1, Line 124: // in a bad state, eg. deleted externally from Kudu, can be dropped.
> Should we log the exception?
Done
http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@124
PS1, Line 124: // in a bad state, eg. deleted externally from Kudu, can be dropped.
> We should have an E2E test here by having a table that is dropped externall
I have tried this but apparently that won't work. I created a table with Impala, dropped it with Hive and tried to drop it with Impala. The TableLoadingException case was covered, that is fine, but later on in CatalogOpExecutor.dropTableOrView() an ImpalaRuntimeException is thrown saying the table no longer exists in HSM and should run invalidate metadata. All in all the updateOwnerPrivileges() function is not invoked.
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 13:25:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13508
to look at the new patch set (#4).
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
IMPALA-8612: Fix sporadic NPE when dropping an authorized table
In the analyze() function of DropTableOrViewStmt it's possible that
serverName_ is not set when analyzer.getTable() throws. As a result
when the Catalog executes the drop table DDL it runs into a failing
Precondition check and throws a NullPointerException when updating
user privileges. Note, to run into the NPE it's required to have
authorization enabled.
Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
---
M fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/13508/4
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 6
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 22:24:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13508
to look at the new patch set (#2).
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
IMPALA-8612: Fix sporadic NPE when dropping an authorized table
In the analyze() function of DropTableOrViewStmt it's possible that
serverName_ is not set when analyzer.getTable() throws. As a result
when the Catalog executes the drop table DDL it runs into a failing
Precondition check and throws a NPE when updating user privileges.
Note, to run into the NPE it's required to have authorization enabled.
Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
---
M fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/13508/2
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13508/4/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:
http://gerrit.cloudera.org:8080/#/c/13508/4/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@131
PS4, Line 131: tableName_.toString()
Just an FYI usually it's better to not call toString() explicitly in the logger since toString() will be lazily called by the logger. For example if we had a very expensive toString() call, calling LOG.info() on a different log level such as WARN or ERROR would not incur an expensive toString() call. I don't think it matters for this, though.
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 15:18:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@40
PS3, Line 40: Drop
> Shouldn't this be DropTableOrViewStmt?
Oh, copy-paste issue. Thanks for spotting!
Done
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@131
PS3, Line 131: "Ignoring TableLoadingException for {}", tableName_.toString());
> nit: it's usually preferable to use the SLF4J log format, e.g. LOG.info("Ig
Done
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@134
PS3, Line 134: ring());
> tableName_.toString() may print "db.tbl": https://github.com/apache/impala/
If you drop the table like "drop table tbl;" then tableName_.toString() won't print "default.tbl" just "tbl". However, providing default as the DB name for the drop table statement will result in printing "default.tbl". I think this is fine and I rewrote the code to use TableName.toString().
Done
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 14:07:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13508
to look at the new patch set (#3).
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
IMPALA-8612: Fix sporadic NPE when dropping an authorized table
In the analyze() function of DropTableOrViewStmt it's possible that
serverName_ is not set when analyzer.getTable() throws. As a result
when the Catalog executes the drop table DDL it runs into a failing
Precondition check and throws a NullPointerException when updating
user privileges. Note, to run into the NPE it's required to have
authorization enabled.
Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
---
M fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/13508/3
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3496/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 14:09:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13508/4/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:
http://gerrit.cloudera.org:8080/#/c/13508/4/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@131
PS4, Line 131: tableName_);
> Just an FYI usually it's better to not call toString() explicitly in the lo
Thanks for sharing! I removed the toString() call even though it doesn't matter here.
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 5
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 16:40:44 +0000
Gerrit-HasComments: Yes