You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/10 01:03:36 UTC

[GitHub] [spark] maropu commented on issue #27436: [SPARK-30705][SQL] Improve CaseWhen sub-expression equality

maropu commented on issue #27436: [SPARK-30705][SQL] Improve CaseWhen sub-expression equality
URL: https://github.com/apache/spark/pull/27436#issuecomment-583918059
 
 
   Is it worth covering more cases in CaseWhen there? Based on [the code comment](https://github.com/apache/spark/blob/b877aac14657832d1b896ea57e06b0d0fd15ee01/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala#L83-L88),  covering more cases could have some overheads to to compute equality of expr trees?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org