You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Neilblaze (via GitHub)" <gi...@apache.org> on 2023/02/24 12:02:19 UTC
[GitHub] [apisix] Neilblaze opened a new pull request, #8939: docs: shift workflow plugin to general category
Neilblaze opened a new pull request, #8939:
URL: https://github.com/apache/apisix/pull/8939
### Description
Currently, the [**_workflow_**](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf72c7b/docs/en/latest/config.json#L187) plugin is in the "[**_serverless_**](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf72c7b/docs/en/latest/config.json#LL180-L181C33)" category (for both [`EN`](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf72c7b/docs/en/latest/config.json#LL180-L187C32) & [`ZH`](https://github.com/apache/apisix/blob/7926408305c36af1003f76c860a9dd027ab32026/docs/zh/latest/config.json#L173&L180)). However, the workflow plugin doesn't run user-defined code, and it doesn't integrate with serverless platforms like AWS-lambda either. Hence, it's recommended to put the workflow plugin in the "[**_general_**](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf72c7b/docs/en/latest/config.json#LL53-L54C30)" category, as it's similar to the batch-requests plugin. The workflow plugin allows user
s to combine multiple actions just like the _batch-requests_ allow users to connect to multiple APIs.
> Moreover, I also noticed that the [`config.json`](https://github.com/apache/apisix/blob/master/docs/zh/latest/config.json) in the Mandarin version ([`ZH`](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf72c7b/docs/zh/latest/config.json#L50-L61)), is missing the inspect plugin ("`plugins/inspect`") which is present in the [`EN`](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf72c7b/docs/en/latest/config.json#L65) version. Hence I added it to the "config.json" for `ZH`.
**Fixes #8422**
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
cc: @navendu-pottekkat , @membphis , @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #8939: docs: shift workflow plugin to general category
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on code in PR #8939:
URL: https://github.com/apache/apisix/pull/8939#discussion_r1118195145
##########
docs/zh/latest/config.json:
##########
@@ -56,9 +56,11 @@
"plugins/gzip",
"plugins/real-ip",
"plugins/server-info",
- "plugins/ext-plugin-post-req",
"plugins/ext-plugin-pre-req",
- "plugins/ext-plugin-post-resp"
+ "plugins/ext-plugin-post-req",
+ "plugins/ext-plugin-post-resp",
+ "plugins/inspect",
Review Comment:
There is no inspect in the Chinese doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Neilblaze commented on a diff in pull request #8939: docs: shift workflow plugin to general category
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on code in PR #8939:
URL: https://github.com/apache/apisix/pull/8939#discussion_r1118275644
##########
docs/zh/latest/config.json:
##########
@@ -56,9 +56,11 @@
"plugins/gzip",
"plugins/real-ip",
"plugins/server-info",
- "plugins/ext-plugin-post-req",
"plugins/ext-plugin-pre-req",
- "plugins/ext-plugin-post-resp"
+ "plugins/ext-plugin-post-req",
+ "plugins/ext-plugin-post-resp",
+ "plugins/inspect",
Review Comment:
@spacewander it should be good now. Thanks! 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat merged pull request #8939: docs: shift workflow plugin to general category
Posted by "navendu-pottekkat (via GitHub)" <gi...@apache.org>.
navendu-pottekkat merged PR #8939:
URL: https://github.com/apache/apisix/pull/8939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org