You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/05 22:05:38 UTC

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5593: GEODE-8577: PubSubNativeRedisAcceptanceTest is flaky

dschneider-pivotal commented on a change in pull request #5593:
URL: https://github.com/apache/geode/pull/5593#discussion_r499898286



##########
File path: geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubNativeRedisAcceptanceTest.java
##########
@@ -16,9 +16,11 @@
 package org.apache.geode.redis.internal.executor.pubsub;
 
 import org.junit.ClassRule;
+import org.junit.Ignore;
 
 import org.apache.geode.NativeRedisTestRule;
 
+@Ignore

Review comment:
       I'd suggest having a geode ticket that will not be fixed until this Ignore can be removed. You can reference that ticket in the Ignore comment. I think it is okay for that to be GEODE-8577. You just need to be careful to not mark GEODE-8577 as fixed when you push this ignore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org