You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/08/09 03:26:03 UTC
[GitHub] [incubator-eventmesh] xwm1992 opened a new pull request, #1119: [MINOR] Fix license check exception
xwm1992 opened a new pull request, #1119:
URL: https://github.com/apache/incubator-eventmesh/pull/1119
Fix license check exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a diff in pull request #1119: [MINOR] Fix license check exception
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1119:
URL: https://github.com/apache/incubator-eventmesh/pull/1119#discussion_r940958471
##########
tools/dependency-check/known-dependencies.txt:
##########
@@ -28,18 +32,25 @@ grpc-protobuf-lite-1.17.1.jar
grpc-stub-1.17.1.jar
grpc-grpclb-1.17.1.jar
gson-2.7.jar
+gson-2.8.2.jar
guava-31.0.1-jre.jar
hamcrest-core-1.3.jar
+httpasyncclient-4.1.3.jar
httpclient-4.5.13.jar
httpcore-4.4.13.jar
+httpcore-nio-4.4.6.jar
ipaddress-5.3.3.jar
j2objc-annotations-1.3.jar
jackson-annotations-2.13.0.jar
jackson-core-2.13.0.jar
jackson-databind-2.13.0.jar
javassist-3.20.0-GA.jar
+javassist-3.21.0-GA.jar
Review Comment:
Please unify the version.
##########
tools/dependency-check/known-dependencies.txt:
##########
@@ -28,18 +32,25 @@ grpc-protobuf-lite-1.17.1.jar
grpc-stub-1.17.1.jar
grpc-grpclb-1.17.1.jar
gson-2.7.jar
+gson-2.8.2.jar
Review Comment:
Please unify the version, we can bound the version to 2.8.2.
##########
tools/dependency-check/known-dependencies.txt:
##########
@@ -118,23 +132,10 @@ simpleclient-0.8.1.jar
simpleclient_common-0.8.1.jar
simpleclient_httpserver-0.8.1.jar
slf4j-api-1.7.30.jar
+snakeyaml-1.23.jar
+snakeyaml-1.30.jar
Review Comment:
Please unify the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1119: [MINOR] Fix license check exception
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1119:
URL: https://github.com/apache/incubator-eventmesh/pull/1119#issuecomment-1209009352
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1119](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51519e0) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/09fc238b1a847b07296d6ff2cd22b017b8dff7c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09fc238) will **increase** coverage by `0.03%`.
> The diff coverage is `7.43%`.
```diff
@@ Coverage Diff @@
## master #1119 +/- ##
===========================================
+ Coverage 9.85% 9.88% +0.03%
- Complexity 626 637 +11
===========================================
Files 368 382 +14
Lines 23341 23628 +287
Branches 2569 2617 +48
===========================================
+ Hits 2300 2336 +36
- Misses 20827 21069 +242
- Partials 214 223 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/eventmesh/common/config/CommonConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29tbW9uQ29uZmlndXJhdGlvbi5qYXZh) | `79.68% <0.00%> (-1.27%)` | :arrow_down: |
| [.../eventmesh/common/config/ConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlndXJhdGlvbldyYXBwZXIuamF2YQ==) | `38.88% <0.00%> (-11.12%)` | :arrow_down: |
| [.../protocol/http/WebhookProtocolTransportObject.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL1dlYmhvb2tQcm90b2NvbFRyYW5zcG9ydE9iamVjdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../common/protocol/http/common/EventMeshRetCode.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9FdmVudE1lc2hSZXRDb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ava/org/apache/eventmesh/common/utils/IPUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9JUFV0aWxzLmphdmE=) | `33.33% <0.00%> (-6.49%)` | :arrow_down: |
| [.../eventmesh/protocol/http/HttpProtocolConstant.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3Byb3RvY29sL2h0dHAvSHR0cFByb3RvY29sQ29uc3RhbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...col/http/resolver/HttpRequestProtocolResolver.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3Byb3RvY29sL2h0dHAvcmVzb2x2ZXIvSHR0cFJlcXVlc3RQcm90b2NvbFJlc29sdmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...esh/registry/consul/service/HeatBeatScheduler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJlZ2lzdHJ5LXBsdWdpbi9ldmVudG1lc2gtcmVnaXN0cnktY29uc3VsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvcmVnaXN0cnkvY29uc3VsL3NlcnZpY2UvSGVhdEJlYXRTY2hlZHVsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/eventmesh/runtime/boot/AbstractHTTPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvQWJzdHJhY3RIVFRQU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/eventmesh/runtime/boot/EventMeshGrpcServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoR3JwY1NlcnZlci5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [58 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1119/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #1119: [MINOR] Fix license check exception
Posted by GitBox <gi...@apache.org>.
qqeasonchen merged PR #1119:
URL: https://github.com/apache/incubator-eventmesh/pull/1119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org