You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/08/21 02:38:56 UTC
[GitHub] trafficserver pull request #884: TS-4737: Remove XML log configuration.
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/884
TS-4737: Remove XML log configuration.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver logs/remove-xml
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/884.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #884
----
commit 2eadd974d3ecf040f161b81add639b0f193ee833
Author: James Peach <jp...@apache.org>
Date: 2016-08-21T02:27:14Z
TS-4737: Remove XML log configuration.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #884: TS-4737: Remove XML log configuration.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/884
FWIW I'm leaving the docs in place for now and assuming that @jsime will take those changes on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #884: TS-4737: Remove XML log configuration.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/884
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/578/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #884: TS-4737: Remove XML log configuration.
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/884
Doing a quick git grep, I a few places that might need more cleanup?
proxy/logging/Log.h: SEND_NON_XML_CUSTOM_FMTS,
proxy/logging/Log.h: SEND_STD_AND_NON_XML_CUSTOM_FMTS,
proxy/logging/LogFilter.cc:LogFilterString::display_as_XML(FILE *fd)
proxy/logging/LogFilter.cc:LogFilterInt::display_as_XML(FILE *fd)
proxy/logging/LogFilter.cc:LogFilterIP::display_as_XML(FILE *fd)
proxy/logging/LogFilter.cc:LogFilterList::display_as_XML(FILE *fd)
proxy/logging/LogFilter.cc: f->display_as_XML(fd);
proxy/logging/LogFilter.h: virtual void display_as_XML(FILE *fd = stdout) = 0;
proxy/logging/LogFilter.h: void display_as_XML(FILE *fd = stdout);
proxy/logging/LogFilter.h: void display_as_XML(FILE *fd = stdout);
proxy/logging/LogFilter.h: void display_as_XML(FILE *fd = stdout);
proxy/logging/LogFilter.h: void display_as_XML(FILE *fd = stdout);
proxy/logging/LogFormat.cc:LogFormat::displayAsXML(FILE *fd)
proxy/logging/LogFormat.h: void displayAsXML(FILE *fd = stdout);
proxy/logging/LogObject.cc:LogObject::displayAsXML(FILE *fd, bool extended)
proxy/logging/LogObject.cc: m_format->displayAsXML(fd);
proxy/logging/LogObject.cc: m_filter_list.display_as_XML(fd);
proxy/logging/LogObject.h: void displayAsXML(FILE *fd = stdout, bool extended = false);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #884: TS-4737: Remove XML log configuration.
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/884
Also, there are several section in docs the refer to the XML format. I'm ok with putting that on a different Jira issue though, and we can rope in @jsime for help (lets just not forget it).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #884: TS-4737: Remove XML log configuration.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/884
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/474/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #884: TS-4737: Remove XML log configuration.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/884
I removed the XML debug routines, but I didn't touch the ``Log::CollationMode`` enum (at least for now).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #884: TS-4737: Remove XML log configuration.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/884
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/568/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #884: TS-4737: Remove XML log configuration.
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/884#discussion_r75608137
--- Diff: doc/admin-guide/files/records.config.en.rst ---
@@ -2651,7 +2651,7 @@ Logging Configuration
===== ======================================================================
For information on sending XML-based custom formats to the collation server,
--- End diff --
get rid of "XML-based" here? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #884: TS-4737: Remove XML log configuration.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/884
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #884: TS-4737: Remove XML log configuration.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/884
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/464/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #884: TS-4737: Remove XML log configuration.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/884#discussion_r75722836
--- Diff: doc/admin-guide/files/records.config.en.rst ---
@@ -2651,7 +2651,7 @@ Logging Configuration
===== ======================================================================
For information on sending XML-based custom formats to the collation server,
--- End diff --
FWIW the main docs jira is [TS-4738](https://issues.apache.org/jira/browse/TS-4738).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---