You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2017/11/30 14:47:24 UTC

[GitHub] carbondata pull request #1565: [WIP][CARBONDATA-1518][Pre-Aggregate]Support ...

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1565#discussion_r154094455
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java ---
    @@ -197,6 +197,7 @@
           thriftColumnSchema.setColumnProperties(properties);
         }
         thriftColumnSchema.setAggregate_function(wrapperColumnSchema.getAggFunction());
    +    thriftColumnSchema.setTimeSeriesFunction(wrapperColumnSchema.getTimeSeriesFunction());
    --- End diff --
    
    I don't think we should add a new field to schema about this, let it be as tableProperty only.


---