You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/03/22 09:23:21 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #264: Fix Xlint options
mdedetrich opened a new pull request, #264:
URL: https://github.com/apache/incubator-pekko/pull/264
As pointed out in https://github.com/apache/incubator-pekko/pull/258#pullrequestreview-1351557344 I got the `Xlint` options wrong in that pull request. This PR fixes that, but in the process of fixing it the Scala compiler for 2.13 specifically found some warnings related to unsealed checking of pattern matches such as
```
[error] /Users/mdedetrich/github/incubator-pekko/docs/src/test/scala/typed/tutorial_4/DeviceGroup.scala:51:5: match may not be exhaustive.
[error] It would fail on the following input: (x: typed.tutorial_4.DeviceGroup.Command forSome x not in (typed.tutorial_4.DeviceGroup.DeviceTerminated, typed.tutorial_4.DeviceManager.RequestDeviceList, typed.tutorial_4.DeviceManager.RequestTrackDevice))
[error] msg match {
```
This is the reason behind adding `-Xlint:-strict-unsealed-patmat` specifically for 2.13. I will make an issue to have a look into this because it does seem we might be able to legitimately fix this in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #264: Fix Xlint options
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #264:
URL: https://github.com/apache/incubator-pekko/pull/264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org