You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/18 12:18:56 UTC
[GitHub] [incubator-nuttx] davids5 opened a new pull request #826: github:
Add PR Template
davids5 opened a new pull request #826: github: Add PR Template
URL: https://github.com/apache/incubator-nuttx/pull/826
@xiaoxiang781216 - Sorry this is so long overdue. Please add the links to running checkpatch in the 2 places indicated or just add the the `commands`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#826: github: Add PR Template
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #826: github: Add PR Template
URL: https://github.com/apache/incubator-nuttx/pull/826#discussion_r410700036
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,68 @@
+# Pull Request Template
+
+## Title guidelines
+
+Following the guidelines for writting good commit messages (https://chris.beams.io/posts/git-commit/) and creating a meaningful title is key in effective team communication.
+
+**do's**
+- stm32h7:Add SDMMC Support
+- nsh:Separate `source` and `sh` for POSIX compliance
+- nxstyle:Fixed Camel case detection
+- drivers/serial:Fixed style violation
+
Review comment:
The English language requires two spaces following a colon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request
#826: github: Add PR Template
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #826: github: Add PR Template
URL: https://github.com/apache/incubator-nuttx/pull/826#discussion_r410700926
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,68 @@
+# Pull Request Template
+
+## Title guidelines
+
+Following the guidelines for writting good commit messages (https://chris.beams.io/posts/git-commit/) and creating a meaningful title is key in effective team communication.
+
+**do's**
+- stm32h7:Add SDMMC Support
Review comment:
```suggestion
- stm32h7: Add SDMMC Support
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request
#826: github: Add PR Template
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #826: github: Add PR Template
URL: https://github.com/apache/incubator-nuttx/pull/826#discussion_r410701003
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,68 @@
+# Pull Request Template
+
+## Title guidelines
+
+Following the guidelines for writting good commit messages (https://chris.beams.io/posts/git-commit/) and creating a meaningful title is key in effective team communication.
+
+**do's**
+- stm32h7:Add SDMMC Support
+- nsh:Separate `source` and `sh` for POSIX compliance
+- nxstyle:Fixed Camel case detection
+- drivers/serial:Fixed style violation
Review comment:
```suggestion
- drivers/serial: Fixed style violation
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request
#826: github: Add PR Template
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #826: github: Add PR Template
URL: https://github.com/apache/incubator-nuttx/pull/826#discussion_r410700974
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,68 @@
+# Pull Request Template
+
+## Title guidelines
+
+Following the guidelines for writting good commit messages (https://chris.beams.io/posts/git-commit/) and creating a meaningful title is key in effective team communication.
+
+**do's**
+- stm32h7:Add SDMMC Support
+- nsh:Separate `source` and `sh` for POSIX compliance
+- nxstyle:Fixed Camel case detection
Review comment:
```suggestion
- nxstyle: Fixed Camel case detection
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request
#826: github: Add PR Template
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #826: github: Add PR Template
URL: https://github.com/apache/incubator-nuttx/pull/826#discussion_r410700947
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,68 @@
+# Pull Request Template
+
+## Title guidelines
+
+Following the guidelines for writting good commit messages (https://chris.beams.io/posts/git-commit/) and creating a meaningful title is key in effective team communication.
+
+**do's**
+- stm32h7:Add SDMMC Support
+- nsh:Separate `source` and `sh` for POSIX compliance
Review comment:
```suggestion
- nsh: Separate `source` and `sh` for POSIX compliance
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #826: github: Add PR
Template
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #826: github: Add PR Template
URL: https://github.com/apache/incubator-nuttx/pull/826#issuecomment-616100551
@xiaoxiang781216 Please use the suggested changes and add the documentation where indicated for running the spelling check and and NX style then we can squash and merge this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #826: github: Add
PR Template
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #826: github: Add PR Template
URL: https://github.com/apache/incubator-nuttx/pull/826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #826: github: Add PR
Template
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #826: github: Add PR Template
URL: https://github.com/apache/incubator-nuttx/pull/826#issuecomment-615868589
Here is a demo view https://github.com/nuttx-to-asf/incubator-nuttx/compare/master-pr-add-PR-template...nuttx-to-asf:master-pr-add-PR-template-test?expand=1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #826: github: Add PR
Template
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #826: github: Add PR Template
URL: https://github.com/apache/incubator-nuttx/pull/826#issuecomment-616123567
> Should we squash the commit into one?
@xiaoxiang781216 Done! Please add the commands to line https://github.com/apache/incubator-nuttx/pull/826/files#diff-195a635ad245ded9076330e31134bd80R68 and 60
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services