[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #130: Scala 3 support

["jrudolph (via GitHub)" <gi...@apache.org>]

jrudolph commented on code in PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#discussion_r1179077650


##########
http-core/src/test/scala/org/apache/pekko/http/impl/model/parser/HttpHeaderSpec.scala:
##########
@@ -377,7 +377,10 @@ class HttpHeaderSpec extends AnyFreeSpec with Matchers {
     "If-Match dispatching" in {

Review Comment:
   We can also just remove the test which is probably not relevant any more.



##########
docs/src/test/scala/docs/http/scaladsl/server/directives/MiscDirectivesExamplesSpec.scala:
##########
@@ -131,7 +132,7 @@ class MiscDirectivesExamplesSpec extends RoutingSpec with CompileOnlySpec {
 
     // tests:
     def entityOfSize(size: Int) =
-      HttpEntity(ContentTypes.`text/plain(UTF-8)`, "0" * size)
+      HttpEntity(ContentTypes.`text/plain(UTF-8)`, List.fill(size)('0').mkString)

Review Comment:
   A bit ugly but what can you do... It's related to a conflict where `NameReceptacle` also adds an `*` extension method that seems to be more nicely resolved in Scala 2.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org