[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #21912: feat(ssh-tunnelling): Setup SSH Tunneling Commands for Database Connections

[GitBox <gi...@apache.org>]

Antonio-RiveroMartnez commented on code in PR #21912:
URL: https://github.com/apache/superset/pull/21912#discussion_r1037432242


##########
superset/databases/commands/test_connection.py:
##########
@@ -90,6 +91,14 @@ def run(self) -> None:  # pylint: disable=too-many-statements
             database.set_sqlalchemy_uri(uri)
             database.db_engine_spec.mutate_db_for_connection_test(database)
 
+            # Generate tunnel if present in the properties
+            ssh_tunnel = None

Review Comment:
   Fixed in the API PR pointing to this branch: https://github.com/apache/superset/pull/22199



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org