[GitHub] JaroslavTulach commented on a change in pull request #425: Netbeans 352

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #425: Netbeans 352
URL: https://github.com/apache/incubator-netbeans/pull/425#discussion_r169370596
 
 

 ##########
 File path: o.n.core/src/org/netbeans/core/ui/ProductInformationPanel.java
 ##########
 @@ -94,8 +98,30 @@
     })
     public ProductInformationPanel() {
         initComponents();
+        descripTemplate = NbBundle.getMessage(ProductInformationPanel.class,
+                "LBL_description");
 
 Review comment:
   Enhancing branding this way is is also an API change, so you can still document it in `arch.xml` (I don't think there is `category="branding"`, if not, use `"property"`) and record it in `apichanges.xml` files + bump the version of the module. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists