You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "rmuir (via GitHub)" <gi...@apache.org> on 2024/12/17 02:20:27 UTC
[PR] aws jmh benchmark cleanups [lucene]
rmuir opened a new pull request, #14072:
URL: https://github.com/apache/lucene/pull/14072
This script lets you benchmark a patch across 10 different cpu types in parallel, just copy the branch name from PR and pass to `make`, along with any jmh args if you dont want to run all benchmarks, for example:
```
make PATCH_BRANCH=ChrisHegarty:unroll_by_2 JMH_ARGS='floatDotProductVector -p size=1024'
```
It creates a combined `build/report.txt` by CPU, suitable for copy/pasting into a PR.
Apply some cleanups:
* Remove hardcoded lucene 10 jar, which was breaking the benchie: use a glob pattern instead.
* Add graviton4 instance type (c8g) to the benchmark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] aws jmh benchmark cleanups [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #14072:
URL: https://github.com/apache/lucene/pull/14072#issuecomment-2549721537
@ChrisHegarty take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] aws jmh benchmark cleanups [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #14072:
URL: https://github.com/apache/lucene/pull/14072#issuecomment-2549619333
OK, we can change that to https. I'm pretty sure it doesn't work for you because no agent was forwarded. i have in my ssh config:
```
AddKeysToAgent yes
ForwardAgent yes
```
This is just old habits because https clones are unreliable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] aws jmh benchmark cleanups [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir merged PR #14072:
URL: https://github.com/apache/lucene/pull/14072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] aws jmh benchmark cleanups [lucene]
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #14072:
URL: https://github.com/apache/lucene/pull/14072#issuecomment-2551481342
@rmuir this LGTM. I clearly have some misconfiguration and/or quirkiness in my ssh setup, so no need to do too much to appease me. I'm also not proficient with ansible!
I'm silly and it took me too long to determine that to debug a failure I need to use the `lucene` user to log into the VM, e.g. `ssh lucene@..` (rather than ec2-user)
I also needed to set `ServerAliveInterval` to say `30` in my case, otherwise the script just appeared to "hang" in `Assemble Sources`. ( I just created an `ansible.cfg` with `[ssh_connection] ssh_args = -o ServerAliveInterval=30`). Again, a small gotcha on my side. But worth a note about ssh config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] aws jmh benchmark cleanups [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #14072:
URL: https://github.com/apache/lucene/pull/14072#issuecomment-2551508242
@ChrisHegarty I want to make it so anybody can use it :)
I understand the SSH reliability issue as I have experienced it before. The issue is that i have sub-10ms ping time to us-east-1 region, so I don't see your problem. I will fix the ssh defaults here, I'll do it as a followup PR.
Typically I set them to something like this, to not overwrite the defaults of reusing-connections and compressing, which are immensely helpful (see "default" in https://docs.ansible.com/ansible/2.7/reference_appendices/config.html#ansible-ssh-args), but just add the keepalives:
```
-C -o ControlMater=auto -o ControlPersist=60s -o ServerAliveInterval=30 -o ServerAliveCountMax=10
```
In conjunction with this, I also set `retries = 3` so that when network fails it will try to reconnect instead of just dying.
I will make followup issue, and just try to set these as env variables in the Makefile so that nobody needs to fight it for good network reliability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] aws jmh benchmark cleanups [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #14072:
URL: https://github.com/apache/lucene/pull/14072#issuecomment-2552134247
merging this one for now: will report back with a PR to make the SSH more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] aws jmh benchmark cleanups [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #14072:
URL: https://github.com/apache/lucene/pull/14072#issuecomment-2549694829
Yeah, i commented out the forwarding and I think i reproduced your issue:
```
fatal: [graviton4]: FAILED! =>
changed: false
cmd: /usr/bin/git ls-remote git@github.com:apache/lucene.git -h refs/heads/main
msg: |-
Warning:********@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
rc: 128
stderr: |-
Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
stderr_lines: <omitted>
stdout: ''
stdout_lines: <omitted>
```
Will push a commit with change to https after i test that it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org