You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/01/02 08:57:46 UTC

[GitHub] wu-sheng opened a new pull request #719: Isolate NetworkAddressRegisterService from ApplicationRegisterService

wu-sheng opened a new pull request #719: Isolate NetworkAddressRegisterService from ApplicationRegisterService
URL: https://github.com/apache/incubator-skywalking/pull/719
 
 
   In order to make the backend data module easier to understand, I proposal to isolate network address register from the current the application register service, and named `NetworkAddressRegisterService`.
   
   The service itselft is very easy. please check the changes for review.
   
   Here are some TODOs:
   1. Rename `ApplicationRegisterService#batchRegister` , because right now, there is no batch register for application. There is always single one application code.
   1. Rename `InstanceDiscoveryService#register`, because this is a key word in C++, ref #696
   
   FYI @ascrutae , this pr will break your automatic test, please fix after merged.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services