You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/11 13:07:23 UTC

[GitHub] [flink] Myasuka opened a new pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

Myasuka opened a new pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification
URL: https://github.com/apache/flink/pull/8693
 
 
   ## What is the purpose of the change
   
   Use notification to abort checkpoint, instead of previous inflexible `CancelCheckpointMarker` mechanism.
   
   ## Brief change log
   
     - No `CancelCheckpointMarker` would be created. If running checkpoint not notified as aborted, tasks would decline that checkpoint if  
       -  Task not ready.
       -   Receieve newer checkpoint barrier in non-blocked channel, which is the same as before.
       -   Meet the end of partition.
     -  If some specific checkpoint is notified as aborted. That checkpoint-to-abort would be stored in `BarrierBuffer`/`BarrierTracker` and `StreamTask`. After that during checkpoint alignment, in sync or async phase of checkpoint, the target checkpoint would be aborted.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Previous `BarrierBufferTest` and `BarrierTrackerTest` could verify the checkpoint abort logic.
     - Add tests in `OneInputStreamTaskTest` to verify the aborted checkpoint could take effect in sync phase and async phase.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **yes**
     - If yes, how is the feature documented? **JavaDocs**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services