You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/09/20 10:16:16 UTC
[GitHub] flink pull request #4686: [FLINK-7651] [flip-6] Delay RetryingRegistration i...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4686
[FLINK-7651] [flip-6] Delay RetryingRegistration in case of connection error
## What is the purpose of the change
Similar to a registration error we should also delay the retrying registration in case of
connection error which could happen if the remote endpoint has not been started yet.
## Brief change log
- delay `RetryingRegistration` in case of connection error.
## Verifying this change
This change is already covered by existing tests, such as `RetryingRegistrationTest#testRetryConnectOnFailure`. I simply added a time measurement which is used to check that the retrying is delayed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink addRetryingRegistrationDelay
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4686.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4686
----
commit e63daa5f35b7ed064fc952ddf8d322f8f06493c1
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-09-20T10:04:58Z
[FLINK-7651] [flip-6] Delay RetryingRegistration in case of connection error
Similar to a registration error we should also delay the retrying registration in case of
connection error which could happen if the remote endpoint has not been started yet.
----
---
[GitHub] flink pull request #4686: [FLINK-7651] [flip-6] Delay RetryingRegistration i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4686
---
[GitHub] flink issue #4686: [FLINK-7651] [flip-6] Delay RetryingRegistration in case ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4686
Travis passed. Merging this PR.
---