You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2026/10/07 16:34:10 UTC

svn commit: r1938865 - pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common

Author: tilman
Date: Wed Oct  7 16:34:10 2026
New Revision: 1938865

Log:
PDFBOX-6274, PDFBOX-6275: fix bug, improve javadoc, as found by copilot

Modified:
   pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java
   pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNumberTreeNode.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java	Wed Oct  7 16:16:30 2026	(r1938864)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java	Wed Oct  7 16:34:10 2026	(r1938865)
@@ -407,7 +407,7 @@ public abstract class PDNameTreeNode<T e
     }
 
     /**
-     * This will get a map of names on ALL levels. The key will be a string,
+     * This will get a flattened recursive map of names on ALL levels. The key will be a string,
      * and the value will depend on where this class is being used.
      *
      * @return ordered map of COS objects, never null.
@@ -417,7 +417,7 @@ public abstract class PDNameTreeNode<T e
     public Map<String, T> getTreeAsMap() throws IOException
     {
         Map<String, T> names = getNames();
-        if (getNames() == null)
+        if (names == null)
         {
             names = new LinkedHashMap<>();
         }

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNumberTreeNode.java
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNumberTreeNode.java	Wed Oct  7 16:16:30 2026	(r1938864)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNumberTreeNode.java	Wed Oct  7 16:34:10 2026	(r1938865)
@@ -369,7 +369,7 @@ public class PDNumberTreeNode implements
     }
 
     /**
-     * This will return a map of numbers on ALL levels. The key will be a java.lang.Integer, the
+     * This will return a flattened recursive map of numbers on ALL levels. The key will be a java.lang.Integer, the
      * value will depend on where this class is being used.
      *
      * @return A map of COS objects.