You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2007/01/15 17:03:14 UTC
svn commit: r496378 - in
/directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap:
codec/add/ schema/ schema/syntax/
Author: elecharny
Date: Mon Jan 15 08:03:14 2007
New Revision: 496378
URL: http://svn.apache.org/viewvc?view=rev&rev=496378
Log:
Removed some warning from findBugs
Modified:
directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/codec/add/AddRequestTest.java
directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/SchemaUtilsTest.java
directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/SchemaParserDITStructureRuleDescriptionTest.java
directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/SchemaParserMatchingRuleDescriptionTest.java
Modified: directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/codec/add/AddRequestTest.java
URL: http://svn.apache.org/viewvc/directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/codec/add/AddRequestTest.java?view=diff&rev=496378&r1=496377&r2=496378
==============================================================================
--- directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/codec/add/AddRequestTest.java (original)
+++ directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/codec/add/AddRequestTest.java Mon Jan 15 08:03:14 2007
@@ -95,7 +95,6 @@
0x04, 0x05, 't', 'e', 's', 't', '3',
} );
- String decodedPdu = StringTools.dumpBytes( stream.array() );
stream.flip();
// Allocate a LdapMessage Container
@@ -174,23 +173,6 @@
// Check the length
assertEquals( 0x59, message.computeLength() );
-
- // Check the encoding
- /* Do not check that because the attributes order may not be kept
- try
- {
- ByteBuffer bb = message.encode( null );
-
- String encodedPdu = StringTools.dumpBytes( bb.array() );
-
- assertEquals( encodedPdu, decodedPdu );
- }
- catch ( EncoderException ee )
- {
- ee.printStackTrace();
- fail( ee.getMessage() );
- }
- */
}
Modified: directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/SchemaUtilsTest.java
URL: http://svn.apache.org/viewvc/directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/SchemaUtilsTest.java?view=diff&rev=496378&r1=496377&r2=496378
==============================================================================
--- directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/SchemaUtilsTest.java (original)
+++ directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/SchemaUtilsTest.java Mon Jan 15 08:03:14 2007
@@ -170,19 +170,15 @@
StringBuffer buf = new StringBuffer();
assertEquals( "", SchemaUtils.render( buf, ( String[] ) null ).toString() );
- buf = new StringBuffer();
assertEquals( "", SchemaUtils.render( new String[]
{} ).toString() );
- buf = new StringBuffer();
assertEquals( "'name1'", SchemaUtils.render( new String[]
{ "name1" } ).toString() );
- buf = new StringBuffer();
assertEquals( "( 'name1' 'name2' )", SchemaUtils.render( new String[]
{ "name1", "name2" } ).toString() );
- buf = new StringBuffer();
assertEquals( "( 'name1' 'name2' 'name3' )", SchemaUtils.render( new String[]
{ "name1", "name2", "name3" } ).toString() );
}
Modified: directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/SchemaParserDITStructureRuleDescriptionTest.java
URL: http://svn.apache.org/viewvc/directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/SchemaParserDITStructureRuleDescriptionTest.java?view=diff&rev=496378&r1=496377&r2=496378
==============================================================================
--- directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/SchemaParserDITStructureRuleDescriptionTest.java (original)
+++ directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/SchemaParserDITStructureRuleDescriptionTest.java Mon Jan 15 08:03:14 2007
@@ -405,7 +405,7 @@
value = "( 1 )";
try
{
- dsrd = parser.parseDITStructureRuleDescription( value );
+ parser.parseDITStructureRuleDescription( value );
fail( "Exception expected, FORM is required" );
}
catch ( ParseException pe )
Modified: directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/SchemaParserMatchingRuleDescriptionTest.java
URL: http://svn.apache.org/viewvc/directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/SchemaParserMatchingRuleDescriptionTest.java?view=diff&rev=496378&r1=496377&r2=496378
==============================================================================
--- directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/SchemaParserMatchingRuleDescriptionTest.java (original)
+++ directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/SchemaParserMatchingRuleDescriptionTest.java Mon Jan 15 08:03:14 2007
@@ -202,7 +202,7 @@
value = "( 1.2.3.4.5.6.7.8.9.0 )";
try
{
- mrd = parser.parseMatchingRuleDescription( value );
+ parser.parseMatchingRuleDescription( value );
fail( "Exception expected, SYNTAX is required" );
}
catch ( ParseException pe )