You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "HoustonPutman (via GitHub)" <gi...@apache.org> on 2023/08/17 19:08:11 UTC
[GitHub] [solr] HoustonPutman opened a new pull request, #1849: SOLR-16941: Use smarter default Solr URL in CLI
HoustonPutman opened a new pull request, #1849:
URL: https://github.com/apache/solr/pull/1849
https://issues.apache.org/jira/browse/SOLR-16941
I've also updated one of the SSL tests to show that this works (defaulting the scheme at least)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [GitHub] [solr] HoustonPutman commented on pull request #1849: SOLR-16941: Use smarter default Solr URL in CLI
Posted by Eric Pugh <ep...@opensourceconnections.com>.
Can you add a jira so we don’t forget. Nice fix to the help command
arguments too.
On Fri, Aug 18, 2023 at 2:24 PM HoustonPutman (via GitHub) <gi...@apache.org>
wrote:
>
> HoustonPutman commented on PR #1849:
> URL: https://github.com/apache/solr/pull/1849#issuecomment-1684277281
>
> Ok fixed the issues. @epugh Going forward (10.0) the `package` tool
> should probably work like the rest of the tools, with regards to the Solr
> Port.
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
> For additional commands, e-mail: issues-help@solr.apache.org
>
>
[GitHub] [solr] epugh commented on a diff in pull request #1849: SOLR-16941: Use smarter default Solr URL in CLI
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #1849:
URL: https://github.com/apache/solr/pull/1849#discussion_r1297751569
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -97,13 +97,13 @@ public class SolrCLI implements CLIO {
.required(false)
.desc(
"Base Solr URL, which can be used to determine the zkHost if that's not known; defaults to: "
- + DEFAULT_SOLR_URL
+ + getDefaultSolrUrl()
+ '.')
.build();
public static final Option OPTION_VERBOSE =
Option.builder("verbose").required(false).desc("Enable more verbose command output.").build();
- // should this be boolean or just a otption?
+ // should this be boolean or just an option?
Review Comment:
thank you for fixing this typo... it' bugged me for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1849: SOLR-16941: Use smarter default Solr URL in CLI
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1849:
URL: https://github.com/apache/solr/pull/1849#issuecomment-1684277281
Ok fixed the issues. @epugh Going forward (10.0) the `package` tool should probably work like the rest of the tools, with regards to the Solr Port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1849: SOLR-16941: Use smarter default Solr URL in CLI
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #1849:
URL: https://github.com/apache/solr/pull/1849#discussion_r1297753161
##########
solr/packaging/test/test_ssl.bats:
##########
@@ -54,8 +54,8 @@ teardown() {
solr start -c
solr assert --started https://localhost:8983/solr --timeout 5000
- run curl --cacert "$ssl_dir/solr-ssl.pem" 'https://localhost:8983/solr/admin/collections?action=CREATE&collection.configName=_default&name=test&numShards=2&replicationFactor=1&router.name=compositeId&wt=json'
- assert_output --partial '"status":0'
+ run solr create -c test -s 2
Review Comment:
Did you mean this change? I guess this is demonstrating that bin/solr create works with https? When you define those variables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a diff in pull request #1849: SOLR-16941: Use smarter default Solr URL in CLI
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on code in PR #1849:
URL: https://github.com/apache/solr/pull/1849#discussion_r1298649841
##########
solr/packaging/test/test_ssl.bats:
##########
@@ -54,8 +54,8 @@ teardown() {
solr start -c
solr assert --started https://localhost:8983/solr --timeout 5000
- run curl --cacert "$ssl_dir/solr-ssl.pem" 'https://localhost:8983/solr/admin/collections?action=CREATE&collection.configName=_default&name=test&numShards=2&replicationFactor=1&router.name=compositeId&wt=json'
- assert_output --partial '"status":0'
+ run solr create -c test -s 2
Review Comment:
Yep, it's to test the usage!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1849: SOLR-16941: Use smarter default Solr URL in CLI
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1849:
URL: https://github.com/apache/solr/pull/1849#issuecomment-1684166801
> This just touches bin/solr, what about bin/solr.cmd?
Not exactly sure but from my surface level research, the windows variables do not need to be exported like they do in bash, so there's nothing to change. The bash changes are just to export the variables we use in the CLI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman merged pull request #1849: SOLR-16941: Use smarter default Solr URL in CLI
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman merged PR #1849:
URL: https://github.com/apache/solr/pull/1849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1849: SOLR-16941: Use smarter default Solr URL in CLI
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #1849:
URL: https://github.com/apache/solr/pull/1849#discussion_r1298308801
##########
solr/packaging/test/test_ssl.bats:
##########
@@ -54,8 +54,8 @@ teardown() {
solr start -c
solr assert --started https://localhost:8983/solr --timeout 5000
- run curl --cacert "$ssl_dir/solr-ssl.pem" 'https://localhost:8983/solr/admin/collections?action=CREATE&collection.configName=_default&name=test&numShards=2&replicationFactor=1&router.name=compositeId&wt=json'
- assert_output --partial '"status":0'
+ run solr create -c test -s 2
Review Comment:
I looked, and I see another curl example elsewhere in the tests. I actually like the example of using curl with the `solr-ssl.pem`, it helped me understand how to interact with Solr in SSL ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org