You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2015/06/17 12:14:01 UTC
[1/2] git commit: updated refs/heads/master to acab743
Repository: cloudstack
Updated Branches:
refs/heads/master 5a3e57e6b -> acab743aa
Re-run travis
Signed-off-by: Daan Hoogland <da...@gmail.com>
This closes #452
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/acab743a
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/acab743a
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/acab743a
Branch: refs/heads/master
Commit: acab743aa1faa6e973a20642bb38028154dd196e
Parents: 380ac0c
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Mon Jun 15 17:35:39 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Wed Jun 17 12:13:46 2015 +0200
----------------------------------------------------------------------
engine/schema/src/com/cloud/service/ServiceOfferingVO.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/acab743a/engine/schema/src/com/cloud/service/ServiceOfferingVO.java
----------------------------------------------------------------------
diff --git a/engine/schema/src/com/cloud/service/ServiceOfferingVO.java b/engine/schema/src/com/cloud/service/ServiceOfferingVO.java
index b93f81a..9c755df 100644
--- a/engine/schema/src/com/cloud/service/ServiceOfferingVO.java
+++ b/engine/schema/src/com/cloud/service/ServiceOfferingVO.java
@@ -310,7 +310,7 @@ public class ServiceOfferingVO extends DiskOfferingVO implements ServiceOffering
}
public String getDetail(String name) {
- return details != null ? details.get(name) : null;
+ return details != null ? details.get(name) : null ;
}
public void setDetail(String name, String value) {
[2/2] git commit: updated refs/heads/master to acab743
Posted by da...@apache.org.
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in ServiceOfferingVO.java Assert isn't used in prod runtime
Signed-off-by: Daan Hoogland <da...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/380ac0cf
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/380ac0cf
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/380ac0cf
Branch: refs/heads/master
Commit: 380ac0cf24c81ea04bca5895c9512fc97fca745e
Parents: 5a3e57e
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Sun Jun 14 21:43:38 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Wed Jun 17 12:13:46 2015 +0200
----------------------------------------------------------------------
engine/schema/src/com/cloud/service/ServiceOfferingVO.java | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/380ac0cf/engine/schema/src/com/cloud/service/ServiceOfferingVO.java
----------------------------------------------------------------------
diff --git a/engine/schema/src/com/cloud/service/ServiceOfferingVO.java b/engine/schema/src/com/cloud/service/ServiceOfferingVO.java
index 805765b..b93f81a 100644
--- a/engine/schema/src/com/cloud/service/ServiceOfferingVO.java
+++ b/engine/schema/src/com/cloud/service/ServiceOfferingVO.java
@@ -310,8 +310,6 @@ public class ServiceOfferingVO extends DiskOfferingVO implements ServiceOffering
}
public String getDetail(String name) {
- assert (details != null) : "Did you forget to load the details?";
-
return details != null ? details.get(name) : null;
}