You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Filippo Diotalevi (JIRA)" <ji...@apache.org> on 2009/09/05 19:41:57 UTC

[jira] Created: (FELIX-1560) [Shell] Allow to disable Felix Shell default commands

[Shell] Allow to disable Felix Shell default commands
-----------------------------------------------------

                 Key: FELIX-1560
                 URL: https://issues.apache.org/jira/browse/FELIX-1560
             Project: Felix
          Issue Type: Improvement
    Affects Versions: shell-1.2.0
            Reporter: Filippo Diotalevi
            Assignee: Filippo Diotalevi


Default shell commands (cd, ps, services, version, start, stop, shutdown, ...) are always installed with the Shell Service. 
That makes the shell less customizable, as it is not possible to disable undesired commands (i.e. "shutdown").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-1560) [Shell] Allow to disable Felix Shell default commands

Posted by "Filippo Diotalevi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751775#action_12751775 ] 

Filippo Diotalevi commented on FELIX-1560:
------------------------------------------

My proposal is to allow the user to (optionally) defined a system property:
org.apache.felix.shell.disable=[comma separated list of commands to disable]

i.e
org.apache.felix.shell.disable=shutdown,cd,version

When the Activator starts, it checks the presence of the org.apache.felix.shell.disable system property.
If any command is disabled, the corresponding Command client is not registered.

For backward compatibility, if the system property is not defined all the commands are installed.

---

Let me know if you have any objection/improvement; I'll apply the modification in the coming days unless someone objects.

> [Shell] Allow to disable Felix Shell default commands
> -----------------------------------------------------
>
>                 Key: FELIX-1560
>                 URL: https://issues.apache.org/jira/browse/FELIX-1560
>             Project: Felix
>          Issue Type: Improvement
>          Components: Shell
>    Affects Versions: shell-1.2.0
>            Reporter: Filippo Diotalevi
>            Assignee: Filippo Diotalevi
>             Fix For: shell-1.4.0
>
>
> Default shell commands (cd, ps, services, version, start, stop, shutdown, ...) are always installed with the Shell Service. 
> That makes the shell less customizable, as it is not possible to disable undesired commands (i.e. "shutdown").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-1560) [Shell] Allow to disable Felix Shell default commands

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-1560:
-----------------------------------

    Fix Version/s:     (was: shell-1.4.0)
                   shell-1.6.0

> [Shell] Allow to disable Felix Shell default commands
> -----------------------------------------------------
>
>                 Key: FELIX-1560
>                 URL: https://issues.apache.org/jira/browse/FELIX-1560
>             Project: Felix
>          Issue Type: Improvement
>          Components: Shell
>    Affects Versions: shell-1.2.0
>            Reporter: Filippo Diotalevi
>            Assignee: Filippo Diotalevi
>             Fix For: shell-1.6.0
>
>
> Default shell commands (cd, ps, services, version, start, stop, shutdown, ...) are always installed with the Shell Service. 
> That makes the shell less customizable, as it is not possible to disable undesired commands (i.e. "shutdown").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-1560) [Shell] Allow to disable Felix Shell default commands

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-1560:
-----------------------------------

    Fix Version/s:     (was: shell-1.6.0)

> [Shell] Allow to disable Felix Shell default commands
> -----------------------------------------------------
>
>                 Key: FELIX-1560
>                 URL: https://issues.apache.org/jira/browse/FELIX-1560
>             Project: Felix
>          Issue Type: Improvement
>          Components: Shell
>    Affects Versions: shell-1.2.0
>            Reporter: Filippo Diotalevi
>            Assignee: Filippo Diotalevi
>
> Default shell commands (cd, ps, services, version, start, stop, shutdown, ...) are always installed with the Shell Service. 
> That makes the shell less customizable, as it is not possible to disable undesired commands (i.e. "shutdown").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-1560) [Shell] Allow to disable Felix Shell default commands

Posted by "Filippo Diotalevi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Filippo Diotalevi updated FELIX-1560:
-------------------------------------

      Component/s: Shell
    Fix Version/s: shell-1.4.0

> [Shell] Allow to disable Felix Shell default commands
> -----------------------------------------------------
>
>                 Key: FELIX-1560
>                 URL: https://issues.apache.org/jira/browse/FELIX-1560
>             Project: Felix
>          Issue Type: Improvement
>          Components: Shell
>    Affects Versions: shell-1.2.0
>            Reporter: Filippo Diotalevi
>            Assignee: Filippo Diotalevi
>             Fix For: shell-1.4.0
>
>
> Default shell commands (cd, ps, services, version, start, stop, shutdown, ...) are always installed with the Shell Service. 
> That makes the shell less customizable, as it is not possible to disable undesired commands (i.e. "shutdown").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-1560) [Shell] Allow to disable Felix Shell default commands

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872359#action_12872359 ] 

Richard S. Hall commented on FELIX-1560:
----------------------------------------

With the move to Gogo as the default shell, is this bug even relevant anymore? The commands in Gogo are a separate bundle, so they can be disabled by not deploying them. Please close this bug if switching to Gogo solves this issue. Thanks.

> [Shell] Allow to disable Felix Shell default commands
> -----------------------------------------------------
>
>                 Key: FELIX-1560
>                 URL: https://issues.apache.org/jira/browse/FELIX-1560
>             Project: Felix
>          Issue Type: Improvement
>          Components: Shell
>    Affects Versions: shell-1.2.0
>            Reporter: Filippo Diotalevi
>            Assignee: Filippo Diotalevi
>             Fix For: shell-1.6.0
>
>
> Default shell commands (cd, ps, services, version, start, stop, shutdown, ...) are always installed with the Shell Service. 
> That makes the shell less customizable, as it is not possible to disable undesired commands (i.e. "shutdown").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.