You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "beiwei30 (GitHub)" <gi...@apache.org> on 2019/09/18 12:43:18 UTC

[GitHub] [dubbo-go] beiwei30 opened pull request #209: fix issue #207: common/utils/net_test.go:25 cannot pass

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:

**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #207 

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go/pull/209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #209: fix issue #207: common/utils/net_test.go:25 cannot pass

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls delete this ref. thx.

[ Full content available at: https://github.com/apache/dubbo-go/pull/209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #209: fix issue #207: common/utils/net_test.go:25 cannot pass

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=h1) Report
> Merging [#209](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a977cc9975bd9041816fe87c3f26badbb732eecd?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `63.63%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/209/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #209      +/-   ##
===========================================
- Coverage    65.28%   65.17%   -0.11%     
===========================================
  Files           96       96              
  Lines         6444     6461      +17     
===========================================
+ Hits          4207     4211       +4     
- Misses        1798     1806       +8     
- Partials       439      444       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `63.26% <63.63%> (-8.61%)` | :arrow_down: |
| [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `86.95% <0%> (+4.34%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=footer). Last update [a977cc9...26b50d9](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #209: fix issue #207: common/utils/net_test.go:25 cannot pass

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=h1) Report
> Merging [#209](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a977cc9975bd9041816fe87c3f26badbb732eecd?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `63.63%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/209/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #209      +/-   ##
===========================================
- Coverage    65.28%   65.17%   -0.11%     
===========================================
  Files           96       96              
  Lines         6444     6461      +17     
===========================================
+ Hits          4207     4211       +4     
- Misses        1798     1806       +8     
- Partials       439      444       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `63.26% <63.63%> (-8.61%)` | :arrow_down: |
| [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `86.95% <0%> (+4.34%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=footer). Last update [a977cc9...bf4734a](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks closed pull request #209: fix issue #207: common/utils/net_test.go:25 cannot pass

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] wongoo commented on pull request #209: fix issue #207: common/utils/net_test.go:25 cannot pass

Posted by "wongoo (GitHub)" <gi...@apache.org>.
just return here

[ Full content available at: https://github.com/apache/dubbo-go/pull/209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #209: fix issue #207: common/utils/net_test.go:25 cannot pass

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=h1) Report
> Merging [#209](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a977cc9975bd9041816fe87c3f26badbb732eecd?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `63.63%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/209/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #209      +/-   ##
===========================================
- Coverage    65.28%   65.17%   -0.11%     
===========================================
  Files           96       96              
  Lines         6444     6461      +17     
===========================================
+ Hits          4207     4211       +4     
- Misses        1798     1806       +8     
- Partials       439      444       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `63.26% <63.63%> (-8.61%)` | :arrow_down: |
| [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `86.95% <0%> (+4.34%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=footer). Last update [a977cc9...61a0641](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #209: fix issue #207: common/utils/net_test.go:25 cannot pass

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=h1) Report
> Merging [#209](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a977cc9975bd9041816fe87c3f26badbb732eecd?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `63.63%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/209/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #209      +/-   ##
===========================================
- Coverage    65.28%   65.17%   -0.11%     
===========================================
  Files           96       96              
  Lines         6444     6461      +17     
===========================================
+ Hits          4207     4211       +4     
- Misses        1798     1806       +8     
- Partials       439      444       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `63.26% <63.63%> (-8.61%)` | :arrow_down: |
| [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `86.95% <0%> (+4.34%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=footer). Last update [a977cc9...42715c6](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #209: fix issue #207: common/utils/net_test.go:25 cannot pass

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=h1) Report
> Merging [#209](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a977cc9975bd9041816fe87c3f26badbb732eecd?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `63.88%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/209/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #209      +/-   ##
===========================================
+ Coverage    65.28%   65.28%   +<.01%     
===========================================
  Files           96       96              
  Lines         6444     6462      +18     
===========================================
+ Hits          4207     4219      +12     
- Misses        1798     1801       +3     
- Partials       439      442       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `62% <63.88%> (-9.88%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=footer). Last update [a977cc9...42715c6](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org