You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Tellier Benoit (JIRA)" <se...@james.apache.org> on 2018/01/26 12:43:00 UTC

[jira] [Resolved] (JAMES-2282) Some Cassandra DAOs are not bound in Singleton scope

     [ https://issues.apache.org/jira/browse/JAMES-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tellier Benoit resolved JAMES-2282.
-----------------------------------
    Resolution: Fixed

> Some Cassandra DAOs are not bound in Singleton scope
> ----------------------------------------------------
>
>                 Key: JAMES-2282
>                 URL: https://issues.apache.org/jira/browse/JAMES-2282
>             Project: James Server
>          Issue Type: Bug
>          Components: cassandra, guice
>    Affects Versions: master
>            Reporter: Tellier Benoit
>            Priority: Minor
>
> We encounter some log lines like:
> {code}
> Re-preparing already prepared query is generally an anti-pattern and will likely affect performance. Consider preparing the statement only once. Query='UPDATE mailboxCounters SET unseen=unseen-1 WHERE mailboxId=:mailboxId;'
> Re-preparing already prepared query is generally an anti-pattern and will likely affect performance. Consider preparing the statement only once. Query='UPDATE mailboxCounters SET count=count-1 WHERE mailboxId=:mailboxId;'
> Re-preparing already prepared query is generally an anti-pattern and will likely affect performance. Consider preparing the statement only once. Query='UPDATE mailboxCounters SET unseen=unseen+1 WHERE mailboxId=:mailboxId;'
> Re-preparing already prepared query is generally an anti-pattern and will likely affect performance. Consider preparing the statement only once. Query='INSERT INTO mailbox (id,name,uidvalidity,mailboxbase) VALUES (:id,:name,:uidvalidity,:mailboxbase);'
> {code}
> These DAOs are created every time they are injected by Guice, which leads to re-preparing queries.
> We should rather bind them in scope singleton.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org