You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by tandrup <gi...@git.apache.org> on 2017/04/24 12:24:15 UTC
[GitHub] storm pull request #2085: Adding Cassandra Object Mapper statement builder.
GitHub user tandrup opened a pull request:
https://github.com/apache/storm/pull/2085
Adding Cassandra Object Mapper statement builder.
Allow bolts to emit object annotated with `@Table` and generate CQL for them automatically using the Cassandra object mapper.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tandrup/storm cassandra-object-mapper
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2085
----
commit 05b9980039da8d664314e75581b42c63af159fc8
Author: Mads Tandrup <ma...@maetzke-tandrup.dk>
Date: 2017-04-24T12:13:59Z
Adding Cassandra Object Mapper statement builder.
Allow bolts to emit object annotated with `@Table` and generate CQL for them automatically using the Cassandra object mapper.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2085: STORM-2492: Adding Cassandra Object Mapper statement buil...
Posted by tandrup <gi...@git.apache.org>.
Github user tandrup commented on the issue:
https://github.com/apache/storm/pull/2085
Thanks for the tip @vesense
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2085: STORM-2492: Adding Cassandra Object Mapper statement buil...
Posted by tandrup <gi...@git.apache.org>.
Github user tandrup commented on the issue:
https://github.com/apache/storm/pull/2085
@HeartSaVioR ok. I've updated the pull request to pass the style checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2085: STORM-2492: Adding Cassandra Object Mapper statement buil...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2085
The code itself looks good, but I'm not familiar with Cassandra so not convinced to vote +1 on this.
cc. ing storm-calcite sponsors @ptgoetz @harshach
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2085: STORM-2492: Adding Cassandra Object Mapper stateme...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2085: Adding Cassandra Object Mapper statement builder.
Posted by tandrup <gi...@git.apache.org>.
Github user tandrup commented on the issue:
https://github.com/apache/storm/pull/2085
It fails on
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project storm: Too many files with unapproved license: 3 See RAT report in: /home/travis/build/apache/storm/target/rat.txt -> [Help 1]
```
Do I need to do anything with licenses?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2085: Adding Cassandra Object Mapper statement builder.
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2085
@tandrup Yes, you need to apply apache license to new files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2085: STORM-2492: Adding Cassandra Object Mapper statement buil...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2085
@tandrup
Sorry to visit this PR really late. We have now introduced checkstyle for the master branch, and build is failing due to the violation. Could you fix it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2085: STORM-2492: Adding Cassandra Object Mapper statement buil...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2085
Seems like I should just merge it. +1 again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---