[GitHub] [orc] guiyanakuang commented on a diff in pull request #1431: ORC-1384 Fix ArrayIndexOutOfBoundsException when reading dictionary stream bigger then dictionary

["guiyanakuang (via GitHub)" <gi...@apache.org>]

guiyanakuang commented on code in PR #1431:
URL: https://github.com/apache/orc/pull/1431#discussion_r1128934893


##########
java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java:
##########
@@ -2292,10 +2292,11 @@ private void readDictionaryStream(InStream in) throws IOException {
           int dictionaryBufferSize = dictionaryOffsets[dictionaryOffsets.length - 1];
           dictionaryBuffer = new byte[dictionaryBufferSize];
           int pos = 0;
-          int chunkSize = in.available();
-          byte[] chunkBytes = new byte[chunkSize];
+          //check if dictionary size is smaller than available stream size to avoid ArrayIndexOutOfBoundsException
+          int readSize = Math.min(in.available(), dictionaryBufferSize);
+          byte[] chunkBytes = new byte[readSize];

Review Comment:
   The previous reading code was implemented on the premise that the total amount of data in the stream is the same as the expected amount to be read. I am curious as to why `in.available()` is greater than `dictionaryBufferSize` in your environment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org