[GitHub] [incubator-shardingsphere] beckhampu commented on a change in pull request #3039: sharding-ui-frontend add unit test

[GitBox <gi...@apache.org>]

beckhampu commented on a change in pull request #3039: sharding-ui-frontend add unit test
URL: https://github.com/apache/incubator-shardingsphere/pull/3039#discussion_r324621983
 
 

 ##########
 File path: sharding-ui/sharding-ui-frontend/src/components/Container/index.vue
 ##########
 @@ -18,17 +18,17 @@
 <template>
   <el-container style="height: 100%;">
     <el-aside width="auto">
-      <s-menu :is-collapse="isCollapse"/>
+      <s-menu :is-collapse="isCollapse" />
     </el-aside>
     <el-container>
       <el-header style="padding: 0">
-        <s-head @on-togger="onTogger"/>
+        <s-head class="s-head" @on-togger="onTogger" />
 
 Review comment:
   @wqzwh, maybe we need to improve the configuration of eslint to prevent useless format.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services