You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/02/20 10:48:52 UTC
[GitHub] [libcloud] foospidy opened a new pull request #1432: Make id lower
for consistent uuid generation
foospidy opened a new pull request #1432: Make id lower for consistent uuid generation
URL: https://github.com/apache/libcloud/pull/1432
## Make id lower for consistent uuid generation
### Description
When a node is created, the resource groups name in the id string is lower case. In subsequent calls, like in list_nodes(), for some reason Azure returns the resource groups name in upper case. This results in a different uuid from when create_node is called. This also breaks wait_until_running(). Forcing lower case in _to_node() seems to resolve this issue.
### Status
- done, ready for review
### Checklist
- [x ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami commented on issue #1432: Make id lower for
consistent uuid generation
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1432: Make id lower for consistent uuid generation
URL: https://github.com/apache/libcloud/pull/1432#issuecomment-589938387
Thanks for the contribution.
Tests are failing (will likely need to rename the fixture or or change how the names are handled on the mock http class) so this will need a bit more work.
We will also need some tests for this change and verify it indeed works correctly end to end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] foospidy commented on issue #1432: Make id lower for
consistent uuid generation
Posted by GitBox <gi...@apache.org>.
foospidy commented on issue #1432: Make id lower for consistent uuid generation
URL: https://github.com/apache/libcloud/pull/1432#issuecomment-592186053
@c-w Thanks for the tips on setting up a test. I'll try to look into it soon, hoping I have some time free up within the next few weeks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] c-w commented on issue #1432: Make id lower for
consistent uuid generation
Posted by GitBox <gi...@apache.org>.
c-w commented on issue #1432: Make id lower for consistent uuid generation
URL: https://github.com/apache/libcloud/pull/1432#issuecomment-591113534
@Kami Yes, I agree that we should validate this against a real Azure environment. I have a subscription set up which I'm using for libcloud integration testing which we can use for this.
@foospidy Would it be possible for you to add a test script for the functionality to the [libcloud-tests](https://github.com/c-w/libcloud-tests) repo (e.g. could be as simple as creating a VM and then deleting it again)? The repo executes a suite of integration tests on a schedule so that we get alerted if there are changes in the underlying cloud APIs which cause a breakage in libcloud. Authentication to Azure is handled via a service principal (see the `auth_*` variables in [azure-pipelines-test-azure.yaml](https://github.com/c-w/libcloud-tests/blob/564f24488952ec8d53e20994ec7769a0a423b539/azure-pipelines-test-azure.yaml#L20)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami commented on issue #1432: Make id lower for
consistent uuid generation
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1432: Make id lower for consistent uuid generation
URL: https://github.com/apache/libcloud/pull/1432#issuecomment-591055268
@c-w I assume it it's a good idea to test this with actual Azure deployment, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services